bhyve: fix usage formatting
ClosedPublic
Actions

Authored by novel on May 14 2018, 6:45 AM.

Details

Reviewers

rgrimes
grehan

Commits

rS333712: Add missing newline to end of -c usage string .

Summary

Updating '-c' command line option for topology support added a formatting glitch for usage (bhyve -h) output:

...

-A: create ACPI tables            
-c: number of cpus and/or topology specification       -C: include guest memory in core file                                              
-e: exit on unhandled I/O access

...

Add a new line so each option is on its own line.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

novel created this revision.May 14 2018, 6:45 AM

Herald added a subscriber: imp. · View Herald TranscriptMay 14 2018, 6:45 AM

Harbormaster completed remote builds in B16578: Diff 42508.May 14 2018, 6:45 AM

novel added reviewers: rgrimes, grehan.May 14 2018, 6:46 AM

grehan accepted this revision.May 14 2018, 7:09 AM

This revision is now accepted and ready to land.May 14 2018, 7:09 AM

Thanks for catch Roman, I have prepared a commit and sent it to my mentors for approval, with a fast track 3 day MFC as this made it into stable/11.

Closed by commit rS333712: Add missing newline to end of -c usage string . (authored by rgrimes). · Explain WhyMay 17 2018, 12:18 PM

This revision was automatically updated to reflect the committed changes.

In D15421#325260, @rgrimes wrote:

Thanks for catch Roman, I have prepared a commit and sent it to my mentors for approval, with a fast track 3 day MFC as this made it into stable/11.

Wait! Do you just committed a patch sent by another developer?

@novel have you approved that?

Best

In D15421#326315, @araujo wrote:

In D15421#325260, @rgrimes wrote:

Thanks for catch Roman, I have prepared a commit and sent it to my mentors for approval, with a fast track 3 day MFC as this made it into stable/11.

Wait! Do you just committed a patch sent by another developer?

@novel have you approved that?

Best

Yes, based on the facts: I was the person that committed the original bug, and @novel has a ports commit bit, so could not of committed this to src without approval.

In D15421#326317, @rgrimes wrote:

In D15421#326315, @araujo wrote:

In D15421#325260, @rgrimes wrote:

Thanks for catch Roman, I have prepared a commit and sent it to my mentors for approval, with a fast track 3 day MFC as this made it into stable/11.

Wait! Do you just committed a patch sent by another developer?

@novel have you approved that?

Best

Yes, based on the facts: I was the person that committed the original bug, and @novel has a ports commit bit, so could not of committed this to src without approval.

He could commit as he has the maintainer approve!
Please update yourself regard the practices of the project, lots of people with commit bits in other areas are doing this after we have Phabricator, or otherwise I do believe he would have sent this patch via Bugzilla.

Best,

Hey, either way is fine as long as it gets committed!
Of course It's more pleasant to commit on my own, but it's not a big deal.

Thanks for handling that.

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

bhyve/

bhyverun.c

2 lines

Diff 42658

View Options

head/usr.sbin/bhyve/bhyverun.c

bhyve: fix usage formattingClosedPublicActions