Page MenuHomeFreeBSD
Differential D15457

deskutils/note: Fix dependencies for crypto options
ClosedPublic
Actions

Authored by fernape on May 16 2018, 5:28 PM.
Tags
None
Referenced Files
F109356946: D15457.diff
Tue, Feb 4, 12:13 AM
Unknown Object (File)
Sun, Feb 2, 11:19 PM
Unknown Object (File)
Thu, Jan 30, 4:04 PM
Unknown Object (File)
Thu, Jan 23, 4:30 PM
Unknown Object (File)
Thu, Jan 23, 4:17 PM
Unknown Object (File)
Thu, Jan 23, 2:20 PM
Unknown Object (File)
Dec 31 2024, 2:57 PM
Unknown Object (File)
Dec 4 2024, 12:09 PM
View All Files
Subscribers
mat

Details

Reviewers
tz
tcberner
Commits
rP470289: Fix deskutils/note dependencies for crypto options
Summary

Sent by maintainer via PR 228208
MFH requested

Test Plan
  • portlint -AC OK
  • poudriere builds for {10.4,11.1}{amd64,i386}, 12i386 OK
  • Run test in 10.4amd64 OK

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 16629
Build 16534: arc lint + arc unit

Event Timeline

fernape created this revision.May 16 2018, 5:28 PM
Herald added a subscriber: mat. · View Herald TranscriptMay 16 2018, 5:28 PM
Harbormaster completed remote builds in B16629: Diff 42641.May 16 2018, 5:28 PM
tcberner added a comment.May 16 2018, 8:20 PM

Wouldn't BLOWFISH_IMPLIES=CRYPTO and so on be more sensible?

tcberner accepted this revision.May 16 2018, 8:24 PM

Never mind, didn't notice that CRYPTO wasn't an option.

This revision is now accepted and ready to land.May 16 2018, 8:24 PM
fernape added a comment.May 17 2018, 2:38 PM
In D15457#326202, @tcberner wrote:

Never mind, didn't notice that CRYPTO wasn't an option.

In D15457#326202, @tcberner wrote:

Never mind, didn't notice that CRYPTO wasn't an option.

Does this case fall under blanket approval for the MFH? According to the committers guide:

"Missing dependencies (detected, linked against but not registered via *_DEPENDS)."

Closed by commit rP470289: Fix deskutils/note dependencies for crypto options (authored by fernape). · Explain WhyMay 18 2018, 1:07 PM
This revision was automatically updated to reflect the committed changes.
tcberner added a comment.EditedMay 18 2018, 7:57 PM
In D15457#326335, @fernape wrote:
In D15457#326202, @tcberner wrote:

Never mind, didn't notice that CRYPTO wasn't an option.

In D15457#326202, @tcberner wrote:

Never mind, didn't notice that CRYPTO wasn't an option.

Does this case fall under blanket approval for the MFH? According to the committers guide:

"Missing dependencies (detected, linked against but not registered via *_DEPENDS)."

Rule of thumb: rather ask too often for approval than to little.

fernape added a comment.May 19 2018, 9:59 AM
In D15457#326767, @tcberner wrote:
In D15457#326335, @fernape wrote:
In D15457#326202, @tcberner wrote:

Never mind, didn't notice that CRYPTO wasn't an option.

In D15457#326202, @tcberner wrote:

Never mind, didn't notice that CRYPTO wasn't an option.

Does this case fall under blanket approval for the MFH? According to the committers guide:

"Missing dependencies (detected, linked against but not registered via *_DEPENDS)."

Rule of thumb: rather ask too often for approval than to little.

I filled the MFH field in the commit message. Awaiting confirmation... :)

Revision Contents
Changeset List

PathSize
deskutils/
note/
10 lines

Diff 42641

View Options

deskutils/note/Makefile

Loading...