Use the thread's vnet when iterating over interfaces.
ClosedPublic
Actions

Authored by markj on May 16 2018, 12:42 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 20, 2:52 PM

	Unknown Object (File)
	Thu, Nov 20, 2:51 PM

	Unknown Object (File)
	Thu, Nov 20, 2:50 PM

	Unknown Object (File)
	Thu, Nov 20, 2:44 PM

	Unknown Object (File)
	Oct 19 2025, 7:30 AM

	Unknown Object (File)
	Oct 19 2025, 12:16 AM

	Unknown Object (File)
	Oct 18 2025, 7:22 PM

	Unknown Object (File)
	Oct 18 2025, 6:30 PM

View All 61 Files

Subscribers

imp

Details

Reviewers

sbruno

Commits

rS333702: Fix netdump configuration when VIMAGE is enabled.

Summary

For now, only permit the use of interfaces from vnet0; netdump may only
be configured from the host, and it's not clear to me that interface
names are unique across vnets. This fixes a panic when configuring
netdump with VIMAGE enabled.

Also fix a resource leak that occurs if the priv_check() in set_dumper()
or clear_dumper() fails. Note that netdump_mbuf_drain() is idempotent.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16616
Build 16523: arc lint + arc unit

Event Timeline

markj created this revision.May 16 2018, 12:42 AM

Harbormaster completed remote builds in B16616: Diff 42608.May 16 2018, 12:42 AM

kbowling added a reviewer: sbruno.May 16 2018, 12:44 AM

sbruno accepted this revision.May 16 2018, 3:12 PM

This revision is now accepted and ready to land.May 16 2018, 3:12 PM

Closed by commit rS333702: Fix netdump configuration when VIMAGE is enabled. (authored by markj). · Explain WhyMay 17 2018, 4:09 AM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptMay 17 2018, 4:09 AM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

netdump/

netdump_client.c

23 lines

Diff 42608

View Options

sys/netinet/netdump/netdump_client.c

Use the thread's vnet when iterating over interfaces.ClosedPublicActions