Page MenuHomeFreeBSD
Differential D15415

[New Port] sysutils/dwatch-pwsnoop
ClosedPublic
Actions

Authored by dteske on May 13 2018, 4:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 27, 12:05 AM
Unknown Object (File)
Sat, Apr 27, 12:05 AM
Unknown Object (File)
Sat, Apr 27, 12:05 AM
Unknown Object (File)
Sat, Apr 27, 12:05 AM
Unknown Object (File)
Sat, Apr 27, 12:04 AM
Unknown Object (File)
Fri, Apr 26, 11:31 PM
Unknown Object (File)
Fri, Apr 26, 9:38 PM
Unknown Object (File)
Apr 1 2024, 12:52 PM
View All 73 Files
Subscribers
dbaio

Details

Reviewers
imp
mat
dbaio
Commits
rP469984: [New Port] sysutils/dwatch-pwsnoop
Summary

DTrace module for FreeBSD dwatch(1) to snoop passwords.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 16571
Build 16485: arc lint + arc unit

Event Timeline

dteske created this revision.May 13 2018, 4:29 PM
Harbormaster completed remote builds in B16562: Diff 42483.May 13 2018, 4:29 PM
imp added inline comments.May 13 2018, 5:17 PM
sysutils/dwatch-pwsnoop/Makefile
15

Do or Do Not. There's no commented out :)

If this will work on 11, remove this (and fix the above line). If it won't, uncomment it out.

18

I'm unsure here, isn't there supposed to be a github version/tag to?

dteske updated this revision to Diff 42490.May 13 2018, 6:52 PM

Remove IGNORES and PORTDOCS

Harbormaster completed remote builds in B16568: Diff 42490.May 13 2018, 6:52 PM
dteske marked 2 inline comments as done.May 13 2018, 6:53 PM
dteske added inline comments.
sysutils/dwatch-pwsnoop/Makefile
18

That's the DISTVERSION (I didn't put a DISTVERSIONPREFIX on my tags like some githubbers)

dbaio added a subscriber: dbaio.May 13 2018, 7:27 PM
dbaio added inline comments.
sysutils/dwatch-pwsnoop/Makefile
20–21

You can use options helper here.

do-install-DOCS-on:

You will need to add OPTIONS_DEFINE= DOCS as well.

sysutils/dwatch-pwsnoop/pkg-plist
1 ↗(On Diff #42490)

As it has just one file, you can use PLIST_FILES variable instead.

dteske updated this revision to Diff 42495.May 13 2018, 7:40 PM
dteske marked an inline comment as done.

Convert to PLIST_FILES, add doc option, make portlint happy, etc.

Harbormaster completed remote builds in B16571: Diff 42495.May 13 2018, 7:40 PM
dteske marked 2 inline comments as done.May 13 2018, 7:41 PM

Addressed comments from dbaio

dbaio accepted this revision.May 13 2018, 8:09 PM
This revision is now accepted and ready to land.May 13 2018, 8:09 PM
mat added inline comments.May 13 2018, 8:26 PM
sysutils/dwatch-pwsnoop/pkg-descr
1

The description in this file must be longer than the comment.

dbaio added a comment.May 13 2018, 8:27 PM

Ah, remember to hook it in sysutils/Makefile.

dteske updated this revision to Diff 42500.May 13 2018, 9:26 PM

Add entry to sysutils/Makefile and add more info to pkg-descr

This revision now requires review to proceed.May 13 2018, 9:26 PM
Harbormaster completed remote builds in B16574: Diff 42500.May 13 2018, 9:26 PM
dteske marked an inline comment as done.May 13 2018, 9:26 PM
dbaio accepted this revision.May 13 2018, 10:37 PM
This revision is now accepted and ready to land.May 13 2018, 10:37 PM
dteske added a comment.May 14 2018, 12:00 AM

Waiting for mentor approval (from either imp or mat)

dbaio added a comment.May 14 2018, 12:19 AM
In D15415#325164, @dteske wrote:

Waiting for mentor approval (from either imp or mat)

Oh, sorry, I thought you were waiting approval of someone from ports.

imp accepted this revision.May 14 2018, 12:24 AM

This looks good to my eye. I'd give mat@ 24 hours to opine on your changes in response to his comments.

sysutils/Makefile
288 ↗(On Diff #42500)

IIRC, this is now autogenerated...

dteske added inline comments.May 14 2018, 1:41 AM
sysutils/Makefile
288 ↗(On Diff #42500)

Should I remove it?

dteske added a comment.May 14 2018, 1:42 AM
In D15415#325165, @dbaio wrote:
In D15415#325164, @dteske wrote:

Waiting for mentor approval (from either imp or mat)

Oh, sorry, I thought you were waiting approval of someone from ports.

Your review is always welcome as any others. Your name will go into the Reviewed-by line, but I do need mat/imp to sign-off for Approved-by line.

dbaio added inline comments.May 14 2018, 2:09 AM
sysutils/Makefile
288 ↗(On Diff #42500)

It's autonegerated if you use $PORTSDIR/Tools/scripts/addport.

dteske marked 3 inline comments as done.May 14 2018, 3:03 AM
dteske added inline comments.
sysutils/Makefile
288 ↗(On Diff #42500)

Thanks for the clarifiction.

Closed by commit rP469984: [New Port] sysutils/dwatch-pwsnoop (authored by dteske). · Explain WhyMay 15 2018, 12:30 AM
This revision was automatically updated to reflect the committed changes.
dteske marked an inline comment as done.

Revision Contents
Changeset List

PathSize
sysutils/
dwatch-pwsnoop/
31 lines
3 lines
3 lines

Diff 42495

View Options

sysutils/dwatch-pwsnoop/

Loading...
View Options

sysutils/dwatch-pwsnoop/Makefile

Loading...
View Options

sysutils/dwatch-pwsnoop/distinfo

Loading...
View Options

sysutils/dwatch-pwsnoop/pkg-descr

Loading...