Page MenuHomeFreeBSD

Make camcontrol identify work with nda devices
ClosedPublic

Authored by imp on May 9 2018, 7:56 PM.
Tags
None
Referenced Files
F106666381: D15371.diff
Fri, Jan 3, 2:57 PM
Unknown Object (File)
Thu, Dec 26, 9:46 PM
Unknown Object (File)
Wed, Dec 25, 9:12 PM
Unknown Object (File)
Thu, Dec 12, 4:44 AM
Unknown Object (File)
Nov 26 2024, 3:13 PM
Unknown Object (File)
Nov 22 2024, 2:15 PM
Unknown Object (File)
Nov 11 2024, 11:54 AM
Unknown Object (File)
Sep 19 2024, 2:48 PM
Subscribers

Details

Summary

Make it possible to use print_controller from another program

Rename print_controller to nvme_print_controller. Put it in its
own file for easy inclusion. Move util.c to be nc_util.c to not
conflict with camcontrol. add nvecontrol_ext.h to define shared
interfaces.

Both ATA and NVME have an identify command. They are completely
different, but to the user they are the same. Leverage nvmecontrol's
print_controller code to provide that functionality to camcontrol
identify. Query the path to see what kind of protocol it supports, and
send the most appropriate command down. Refactor nvme_print_dev a
little to make it easy to get the nvme cdata.

Sponsored by: Netflix

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16501
Build 16415: arc lint + arc unit

Event Timeline

the "new" nvme_print_controller() function appears to be missing from your diff. Missing a file?

This revision is now accepted and ready to land.May 9 2018, 8:26 PM
This revision was automatically updated to reflect the committed changes.