Paths

Table of Contentst

Differential D15265

Mk/Uses/Emacs: Add noflavors argument to USES=emacs
ClosedPublic
Actions

Authored by jrm on May 1 2018, 8:14 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, May 11, 2:42 AM

	Unknown Object (File)
	Tue, May 7, 5:35 AM

	Unknown Object (File)
	Tue, May 7, 5:35 AM

	Unknown Object (File)
	Tue, May 7, 5:35 AM

	Unknown Object (File)
	Tue, May 7, 5:34 AM

	Unknown Object (File)
	Tue, May 7, 5:34 AM

	Unknown Object (File)
	Tue, May 7, 5:14 AM

	Unknown Object (File)
	Wed, May 1, 8:25 AM

View All 34 Files

Subscribers

None

Details

Reviewers

des
mat
ashish

Group Reviewers

O5: Ports Framework	(Owns No Changed Paths)
portmgr

Commits

rP469945: Mk/Uses/Emacs: Add noflavors argument to USES=emacs

Summary

Reported by: des

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 16434
Build 16353: arc lint + arc unit

Event Timeline

jrm created this revision.May 1 2018, 8:14 PM

Harbormaster completed remote builds in B16389: Diff 42055.May 1 2018, 8:14 PM

Remove www/emacs-w3m/Makefile that was not intened to be incuded in revision

Harbormaster completed remote builds in B16390: Diff 42056.May 1 2018, 8:17 PM

change conditions when FLAVORS, FLAVOR, and EMACS_FLAVOR are set
comment changes
test all flavors for ports with USES=emacs, no issues related to emacs.mk changes http://pkg.awarnach.mathstat.dal.ca/build.html?mastername=11amd64-default&build=2018-05-04_14h56m02s

Harbormaster completed remote builds in B16434: Diff 42152.May 4 2018, 7:16 PM

mat added inline comments.May 4 2018, 7:28 PM

Mk/Uses/emacs.mk
102	Shouldn't it be set to EMACS_DEFAULT if it is set?

jrm added inline comments.May 4 2018, 7:33 PM

Mk/Uses/emacs.mk
102	`EMACS_FLAVOR` is set to `FLAVOR` when `FLAVOR` is not empty and `FLAVOR` is set to `EMACS_DEFAULT` when appropriate. `EMACS_FLAVOR` is only set to `full` when `FLAVOR` is empty.

Sorry for the delay in follow-up. Looks good to me.

This revision is now accepted and ready to land.May 12 2018, 7:16 PM

Closed by commit rP469945: Mk/Uses/Emacs: Add noflavors argument to USES=emacs (authored by jrm). · Explain WhyMay 14 2018, 6:28 PM

This revision was automatically updated to reflect the committed changes.

Owners added a reviewer: O5: Ports Framework.May 14 2018, 6:28 PM

Herald added a reviewer: portmgr. · View Herald TranscriptMay 14 2018, 6:28 PM

Revision Contents
Changeset List

Path

Size

Mk/

Uses/

44 lines

Diff 42152

Mk/Uses/emacs.mk

Loading...