Differential D15261

Add netdump hooks for vtnet(4).
ClosedPublic
Actions

Authored by markj on May 1 2018, 5:24 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Sep 8, 1:15 PM

	Unknown Object (File)
	Sat, Sep 5, 9:02 PM

	Unknown Object (File)
	Sat, Sep 5, 8:08 AM

	Unknown Object (File)
	Sat, Sep 5, 5:54 AM

	Unknown Object (File)
	Fri, Sep 4, 4:50 AM

	Unknown Object (File)
	Thu, Sep 3, 6:11 AM

	Unknown Object (File)
	Wed, Sep 2, 4:43 PM

	Unknown Object (File)
	Wed, Sep 2, 4:49 AM

Subscribers

Details

Reviewers

bryanv
julian

Commits

rS333290: Add netdump support to vtnet(4).

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16384
Build 16312: arc lint + arc unit

Event Timeline

markj created this revision.May 1 2018, 5:24 PM

Harbormaster completed remote builds in B16384: Diff 42048.May 1 2018, 5:24 PM

markj added a reviewer: bryanv.May 1 2018, 6:00 PM

julian accepted this revision.May 2 2018, 6:24 AM

This revision is now accepted and ready to land.May 2 2018, 6:24 AM

bryanv added inline comments.May 3 2018, 4:39 AM

sys/dev/virtio/network/if_vtnet.c
4029	vtnet_txq_notify can return non-zero but I don't think you consider that an error: if it was able to drain enough completed mbufs it returns non-zero so that the caller can continue transmitting. Since you're transmitting one mbuf here and are polling I think you can just ignore the return value.

markj marked an inline comment as done.May 4 2018, 7:39 PM

bryanv accepted this revision.May 4 2018, 7:42 PM

Closed by commit rS333290: Add netdump support to vtnet(4). (authored by markj). · Explain WhyMay 6 2018, 12:54 AM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptMay 6 2018, 12:54 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

virtio/

network/

81 lines

Diff 42048

sys/dev/virtio/network/if_vtnet.c

Loading...