Page MenuHomeFreeBSD
Differential D15235

www/nextcloud: PHP-flavorize
ClosedPublic
Actions

Authored by brnrd on Apr 30 2018, 9:19 AM.
Tags
None
Referenced Files
F101899938: D15235.diff
Tue, Nov 5, 9:30 AM
Unknown Object (File)
Thu, Oct 17, 6:32 AM
Unknown Object (File)
Wed, Oct 16, 11:07 PM
Unknown Object (File)
Mon, Oct 14, 9:21 AM
Unknown Object (File)
Mon, Oct 14, 2:13 AM
Unknown Object (File)
Fri, Oct 11, 11:16 PM
Unknown Object (File)
Thu, Oct 10, 5:02 PM
Unknown Object (File)
Wed, Oct 9, 6:18 PM
View All Files
Subscribers
None

Details

Reviewers
mat
antoine
Commits
rP468708: www/nextcloud: PHP-flavorize
Summary
www/nextcloud: PHP-flavorize

 - Create flavors for all PHP versions
 - Use releases dir (not pre-)

PR:	227510
Approved by: portmgr
Differential Revision
Test Plan

Builds successful on 11.1/10.4 i386/amd64

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 16357
Build 16289: arc lint + arc unit

Event Timeline

brnrd created this revision.Apr 30 2018, 9:19 AM
Harbormaster completed remote builds in B16351: Diff 41991.Apr 30 2018, 9:19 AM
brnrd edited the test plan for this revision. (Show Details)Apr 30 2018, 10:04 AM
mat requested changes to this revision.Apr 30 2018, 10:36 AM

This will break all package depending on nextcloud.

This revision now requires changes to proceed.Apr 30 2018, 10:36 AM
brnrd added a comment.Apr 30 2018, 10:53 AM
In D15235#321193, @mat wrote:

This will break all package depending on nextcloud.

I assume you are indicating that all dependent ports must also be flavorized?

Prepping an update that updates all dependent ports!

brnrd updated this revision to Diff 41994.Apr 30 2018, 11:32 AM
brnrd edited the test plan for this revision. (Show Details)

flavorsify dependencies too

Harbormaster completed remote builds in B16353: Diff 41994.Apr 30 2018, 11:32 AM
brnrd updated this revision to Diff 41995.Apr 30 2018, 12:05 PM

Complete run-depends change

Harbormaster completed remote builds in B16354: Diff 41995.Apr 30 2018, 12:05 PM
brnrd updated this revision to Diff 41996.Apr 30 2018, 12:07 PM

Add missing changes for nextcloud-tasks

Harbormaster completed remote builds in B16355: Diff 41996.Apr 30 2018, 12:07 PM
mat added a comment.Apr 30 2018, 12:24 PM

Don't pass @${FLAVOR} directly, use @${PHP_FLAVOR}.

brnrd updated this revision to Diff 42005.Apr 30 2018, 3:14 PM

Switch FLAVOR to PHP_FLAVOR

Harbormaster completed remote builds in B16357: Diff 42005.Apr 30 2018, 3:14 PM
mat accepted this revision.Apr 30 2018, 3:29 PM

Looks ok.

This revision is now accepted and ready to land.Apr 30 2018, 3:29 PM
Closed by commit rP468708: www/nextcloud: PHP-flavorize (authored by brnrd). · Explain WhyApr 30 2018, 3:43 PM
This revision was automatically updated to reflect the committed changes.
brnrd added a comment.Apr 30 2018, 3:46 PM

Thanks for the assistance @mat !

I was looking through Mk/Uses/php.mk yet didn't find docs for PHP_PKGNAMESUFFIX and PHP_FLAVOR in the header. Where should I have looked for documentation for this change?

Revision Contents
Changeset List

PathSize
mail/
nextcloud-mail/
5 lines
security/
nextcloud-passman/
5 lines
nextcloud-twofactor_totp/
5 lines
nextcloud-twofactor_u2f/
5 lines
www/
nextcloud-calendar/
5 lines
nextcloud-contacts/
5 lines
nextcloud-notes/
5 lines
nextcloud-tasks/
5 lines
nextcloud/
5 lines

Diff 42005

View Options

mail/nextcloud-mail/Makefile

Loading...
View Options

security/nextcloud-passman/Makefile

Loading...
View Options

security/nextcloud-twofactor_totp/Makefile

Loading...
View Options

security/nextcloud-twofactor_u2f/Makefile

Loading...
View Options

www/nextcloud-calendar/Makefile

Loading...
View Options

www/nextcloud-contacts/Makefile

Loading...
View Options

www/nextcloud-notes/Makefile

Loading...
View Options

www/nextcloud-tasks/Makefile

Loading...
View Options

www/nextcloud/Makefile

Loading...