Page MenuHomeFreeBSD

www/nextcloud: PHP-flavorize
ClosedPublic

Authored by brnrd on Apr 30 2018, 9:19 AM.

Details

Summary
www/nextcloud: PHP-flavorize

 - Create flavors for all PHP versions
 - Use releases dir (not pre-)

PR:	227510
Approved by: portmgr
Differential Revision
Test Plan

Builds successful on 11.1/10.4 i386/amd64

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

brnrd created this revision.Apr 30 2018, 9:19 AM
brnrd edited the test plan for this revision. (Show Details)Apr 30 2018, 10:04 AM
mat requested changes to this revision.Apr 30 2018, 10:36 AM

This will break all package depending on nextcloud.

This revision now requires changes to proceed.Apr 30 2018, 10:36 AM
In D15235#321193, @mat wrote:

This will break all package depending on nextcloud.

I assume you are indicating that all dependent ports must also be flavorized?

Prepping an update that updates all dependent ports!

brnrd edited the test plan for this revision. (Show Details)Apr 30 2018, 11:32 AM
brnrd updated this revision to Diff 41994.

flavorsify dependencies too

brnrd updated this revision to Diff 41995.Apr 30 2018, 12:05 PM

Complete run-depends change

brnrd updated this revision to Diff 41996.Apr 30 2018, 12:07 PM

Add missing changes for nextcloud-tasks

mat added a comment.Apr 30 2018, 12:24 PM

Don't pass @${FLAVOR} directly, use @${PHP_FLAVOR}.

brnrd updated this revision to Diff 42005.Apr 30 2018, 3:14 PM

Switch FLAVOR to PHP_FLAVOR

mat accepted this revision.Apr 30 2018, 3:29 PM

Looks ok.

This revision is now accepted and ready to land.Apr 30 2018, 3:29 PM
This revision was automatically updated to reflect the committed changes.
brnrd added a comment.Apr 30 2018, 3:46 PM

Thanks for the assistance @mat !

I was looking through Mk/Uses/php.mk yet didn't find docs for PHP_PKGNAMESUFFIX and PHP_FLAVOR in the header. Where should I have looked for documentation for this change?