Stop using fuswintr() and suswintr() in the profiler.
ClosedPublic
Actions

Authored by brooks on Apr 16 2018, 5:53 PM.

Details

Reviewers

kib
jhb

Commits

rS332650: Stop using fuswintr() and suswintr() in the profiler.

Summary

Always take the AST path rather than calling MD functions which are
often implemented as always failing. The is the case on amd64, arm,
i386, and powerpc. This optimization (inherited from 4.4 Lite) is a
pessimization on those architectures and is the sole use of these
functions. They will be removed in a seperate commit.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16179
Build 16132: arc lint + arc unit

Event Timeline

brooks created this revision.Apr 16 2018, 5:53 PM

Harbormaster completed remote builds in B16170: Diff 41538.Apr 16 2018, 5:53 PM

brooks mentioned this in D15102: Remove the unused fuwintr() and suiwintr() functions..Apr 16 2018, 5:56 PM

kib accepted this revision.Apr 16 2018, 7:11 PM

This revision is now accepted and ready to land.Apr 16 2018, 7:11 PM

jhb added inline comments.Apr 16 2018, 8:02 PM

sys/kern/subr_prof.c
482–483	This comment probably needs a bit of an update as it is no longer like the previous function.

Don't compute things that aren't used in addupc_intr().
Update commment on addupc_task().

This revision now requires review to proceed.Apr 16 2018, 9:39 PM

Harbormaster completed remote builds in B16179: Diff 41554.Apr 16 2018, 9:39 PM

brooks marked an inline comment as done.Apr 16 2018, 9:39 PM

kib accepted this revision.Apr 17 2018, 12:30 PM

This revision is now accepted and ready to land.Apr 17 2018, 12:30 PM

brooks retitled this revision from Stop using fuswintr() and suswintr(). to Stop using fuswintr() and suswintr() in the profiler..Apr 17 2018, 4:09 PM

brooks edited the summary of this revision. (Show Details)

Closed by commit rS332650: Stop using fuswintr() and suswintr() in the profiler. (authored by brooks). · Explain WhyApr 17 2018, 4:37 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptApr 17 2018, 4:37 PM