loader: make sure we do not return garbage from help_getnext
ClosedPublic
Actions

Authored by tsoome on Apr 16 2018, 8:55 AM.

Tags

None

Referenced Files

	F157782198: D15082.id41501.diff
	Mon, May 25, 3:10 AM

	Unknown Object (File)
	Fri, May 22, 7:56 AM

	Unknown Object (File)
	Thu, May 21, 9:10 PM

	Unknown Object (File)
	Wed, May 20, 1:45 AM

	Unknown Object (File)
	Tue, Apr 28, 1:16 PM

	Unknown Object (File)
	Tue, Apr 28, 1:09 PM

	Unknown Object (File)
	Apr 21 2026, 12:34 PM

	Unknown Object (File)
	Apr 21 2026, 12:27 PM

View All 94 Files

Subscribers

imp

Details

Reviewers

bapt

Commits

rS332560: loader: make sure we do not return garbage from help_getnext

Summary

Since we do free subtopic and desc in help_getnext(), we need to set them also
NULL, so we make sure we dont get double free().

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tsoome created this revision.Apr 16 2018, 8:55 AM

Herald added a subscriber: imp. · View Herald TranscriptApr 16 2018, 8:55 AM

Harbormaster completed remote builds in B16156: Diff 41501.Apr 16 2018, 8:55 AM

bapt accepted this revision.Apr 16 2018, 12:42 PM

This revision is now accepted and ready to land.Apr 16 2018, 12:42 PM

Closed by commit rS332560: loader: make sure we do not return garbage from help_getnext (authored by tsoome). · Explain WhyApr 16 2018, 12:46 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

stand/

common/

commands.c

2 lines

Diff 41508

View Options

head/stand/common/commands.c

loader: make sure we do not return garbage from help_getnextClosedPublicActions