This is a heavily streamlined version of gptboot that instead of looking for a UFS filesystem instead looks for an ISO image residing on the same device it got booted from.
Details
Details
- Reviewers
imp mav bcr - Group Reviewers
manpages - Commits
- rS332084: Add isoboot(8) for booting BIOS systems from HDDs containing ISO images.
Constructed a PMBR/GPT image with this in a freebsd-boot partition and stuck that in front of an ISO image and booted it.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 15908
Event Timeline
Comment Actions
Fix copyright on cd9660read.c.
When I first wrote this code it was inside a version of boot2.c, then got transplanted to a version of gptboot.c and then split out into cd9660read.c and so it ended up with gptboot.c's copyright when it should've had cd9660.c's.
Comment Actions
I'm a little confused. I think I detect vestiges of time when this used boot2, which it no longer does. What's the current design?
| stand/i386/isoboot/Makefile | ||
|---|---|---|
| 23 | shouldn't this be isoboot? Is it even used? | |
| 68 | I thought it was fine with them finally. | |
| stand/i386/isoboot/isoboot.c | ||
| 82 | Are these still in use? I thought we killed them in the 4.x time frame. | |
| 212 | This is silly. | |
| stand/i386/isoboot/Makefile | ||
|---|---|---|
| 44 | Is there a size limit for isoboot? If so, we should enforce it here... | |
| stand/i386/isoboot/isoboot.c | ||
| 62 | Won't block this review, but we need to kill the umpteen million copies of this. | |
| 124 | Seems like this should be common in libi386... | |
| 317 | Do you need this? This isn't boot2 as well, so at least you should update the comment :) | |
| 425 | Seems like this should be common too, but that may be beyond the scope here... | |
| stand/i386/isoboot/isoboot.c | ||
|---|---|---|
| 3 | No, not enough changes to warrant it. | |