Page MenuHomeFreeBSD
Differential D14795

Update emulators/mupen64plus-qt to 1.11
ClosedPublic
Actions

Authored by fernape on Mar 22 2018, 3:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 23, 6:19 AM
Unknown Object (File)
Fri, Apr 19, 2:59 PM
Unknown Object (File)
Feb 23 2024, 9:15 AM
Unknown Object (File)
Feb 23 2024, 9:15 AM
Unknown Object (File)
Feb 23 2024, 9:15 AM
Unknown Object (File)
Feb 23 2024, 9:15 AM
Unknown Object (File)
Feb 22 2024, 10:33 PM
Unknown Object (File)
Jan 20 2024, 6:00 PM
View All 44 Files
Subscribers
None

Details

Reviewers
tz
tcberner
Commits
rP465466: PR: 224942
Summary
  • Update emulators/mupen64plus-qt to 1.11
  • Update to use qt5
  • Fix stage-qa error

This comes from PR 224942. The original patch didn't build because it lacked
the USE_QT5 widgets module.

In addition I added the USE_GL line to avoid a stage-qa error.

portlint -AC is clean, the software runs (tested in 11.1-RELEASE) and builds in
{10.3,10.4,11.1}{amd64,i386} and 12i386. Poudriere logs available:

https://www.dropbox.com/sh/uvrkcm856p2856k/AABl1WRJgEa6p7Q6w180T-Ara?dl=0

I suppose I should let the PR submitter know about the build error. Should I
ask him to send a new patch, ask him to review my proposal?

Test Plan

portlint -AC, make -C emulators/mupe64plus-qt and run the executable

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 15729
Build 15750: arc lint + arc unit

Event Timeline

fernape created this revision.Mar 22 2018, 3:41 PM
Harbormaster completed remote builds in B15719: Diff 40599.Mar 22 2018, 3:41 PM
tcberner requested changes to this revision.Mar 22 2018, 4:37 PM

You can add the URL to the diff to the URL field of the bugzilla report. Then they can chime in here.

emulators/mupen64plus-qt/Makefile
5

^you could switch this to read DISTVERSION

21–24

I would sort this by kind and alphabetically

USE_QT5= core gui network sql widgets xml \
      buildtools_build \
      sql-sqlite3_run
22

You could order the USE_x alphabetically, i.e. move USE_GL above USE_QT5.

But that's just my taste ...

This revision now requires changes to proceed.Mar 22 2018, 4:37 PM
fernape updated this revision to Diff 40617.Mar 22 2018, 10:29 PM

Changes requested by tcberner.

  • Sorting USE_QT5 elements
  • Sorting USE_x
  • Change PORTVERSION for DISTVERSION
Harbormaster completed remote builds in B15729: Diff 40617.Mar 22 2018, 10:29 PM
fernape marked 3 inline comments as done.Mar 22 2018, 10:32 PM
In D14795#311152, @tcberner wrote:

You can add the URL to the diff to the URL field of the bugzilla report. Then they can chime in here.

Done.

Thanks!

fernape added a comment.Mar 23 2018, 6:22 PM
In D14795#311275, @fernape wrote:
In D14795#311152, @tcberner wrote:

You can add the URL to the diff to the URL field of the bugzilla report. Then they can chime in here.

Done.

The submitter accepted the changes in bugzilla.

Thanks!

tcberner accepted this revision.Mar 24 2018, 5:53 PM

Looks good to me.

This revision is now accepted and ready to land.Mar 24 2018, 5:53 PM
Closed by commit rP465466: PR: 224942 (authored by fernape). · Explain WhyMar 24 2018, 7:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
emulators/
mupen64plus-qt/
21 lines
6 lines

Diff 40617

View Options

emulators/mupen64plus-qt/Makefile

Loading...
View Options

emulators/mupen64plus-qt/distinfo

Loading...