Page MenuHomeFreeBSD
Differential D14644

x11/polybar: Many fixes.
ClosedPublic
Actions

Authored by rigoletto on Mar 10 2018, 11:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 22, 7:01 AM
Unknown Object (File)
Sun, Apr 20, 6:04 PM
Unknown Object (File)
Sun, Apr 20, 11:52 AM
Unknown Object (File)
Sun, Apr 20, 11:48 AM
Unknown Object (File)
Sun, Apr 20, 11:46 AM
Unknown Object (File)
Sun, Apr 20, 11:46 AM
Unknown Object (File)
Sun, Apr 20, 11:45 AM
Unknown Object (File)
Sun, Apr 20, 11:45 AM
View All Files
Subscribers
mat
tobik
Contributor Reviewers (ports)

Details

Reviewers
capt_redbeard_protonmail.com
Commits
rP469708: x11/polybar: Disable ALSA by default
Summary

PR: 226507

  • remove ALSA from OPTIONS_DEFAULT (broken)
  • add mpd to working modules list (tested)
  • add menu to working modules (tested)
  • add xworkspaces to working modules (not extensively tested)
  • add github to working modules (tested)
  • add TESTS OPTION
  • fix IPC_DESC. That is a built-in IPC, not i3 related
  • move cpu, memory and others modules to broken (tested)
  • while here do some alphabetizing

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 15703
Build 15731: arc lint + arc unit

Event Timeline

rigoletto created this revision.Mar 10 2018, 11:11 PM
Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptMar 10 2018, 11:11 PM
Harbormaster completed remote builds in B15477: Diff 40141.Mar 10 2018, 11:11 PM
rigoletto edited the summary of this revision. (Show Details)Mar 10 2018, 11:14 PM
rigoletto added a reviewer: capt_redbeard_protonmail.com.
rigoletto updated this revision to Diff 40142.Mar 10 2018, 11:21 PM

Fixing pkg-plist again.

Harbormaster completed remote builds in B15478: Diff 40142.Mar 10 2018, 11:21 PM
rigoletto updated this revision to Diff 40143.Mar 10 2018, 11:22 PM

Fix empty line in a file.

Harbormaster completed remote builds in B15479: Diff 40143.Mar 10 2018, 11:22 PM
rigoletto added a comment.Mar 10 2018, 11:25 PM
This comment was removed by rigoletto.
rigoletto edited the summary of this revision. (Show Details)Mar 10 2018, 11:27 PM
rigoletto retitled this revision from x11/polybar: fix empty pkg-plist and minors. to x11/polybar: many fixes..Mar 21 2018, 4:54 AM
rigoletto edited the summary of this revision. (Show Details)
rigoletto edited the summary of this revision. (Show Details)
rigoletto updated this revision to Diff 40527.Mar 21 2018, 4:57 AM

More fixes.

Harbormaster completed remote builds in B15676: Diff 40527.Mar 21 2018, 4:57 AM
rigoletto updated this revision to Diff 40528.Mar 21 2018, 5:00 AM

Revert the distinfo file. There is not point to commit just timestamp changes.

Harbormaster completed remote builds in B15677: Diff 40528.Mar 21 2018, 5:00 AM
tobik added a subscriber: tobik.Mar 21 2018, 8:47 AM
tobik added inline comments.
x11/polybar/Makefile
53

This seems like a bogus change? Please keep the options helpers sorted.

x11/polybar/pkg-plist
2 ↗(On Diff #40528)

polybar-msg is only built when BUILD_IPC_MSG is turned on, so this needs to either be added back in or we remove the IPC option entirely. It doesn't add any new dependencies AFAICT and we can just always build polybar-msg.

Build with IPC=off:

===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: bin/polybar-msg
===> Error: Plist issues found.
rigoletto updated this revision to Diff 40546.EditedMar 21 2018, 3:57 PM
rigoletto marked 2 inline comments as done.

Fixing and:

  • add TESTS (test suite) OPTION
  • I *temporarily* enabled some xcb-* stuff to see if they change anything related with some known broken modules.

Thanks!

Harbormaster completed remote builds in B15687: Diff 40546.Mar 21 2018, 3:57 PM
rigoletto updated this revision to Diff 40547.Mar 21 2018, 4:01 PM

Cleaning a GH_TAG what should not be in there.

Harbormaster completed remote builds in B15688: Diff 40547.Mar 21 2018, 4:01 PM
rigoletto updated this revision to Diff 40555.EditedMar 21 2018, 5:47 PM
  • more modules tested and working: menu, and xworkspaces.
  • for backlight and xbacklight I get this message:

error: Disabling module "backlight" (reason: Not supported for "DVI-I-0")

I do not know if those were supposed to be working or the message is just right about not being supported.

  • the GitHub module show up but I had no opportunity to actually know if it is working or not.
  • the battery module I do not have how to test, and I will try to proper test the ipc one due tomorrow.
  • The commit 0edaead fix the very annoying bug of tray overlapping other modules. Do you think it worth to bring the port to that commit? See HERE.

Thanks!

Harbormaster completed remote builds in B15693: Diff 40555.Mar 21 2018, 5:47 PM
rigoletto edited the summary of this revision. (Show Details)Mar 21 2018, 5:53 PM
rigoletto edited the summary of this revision. (Show Details)
rigoletto edited the summary of this revision. (Show Details)Mar 21 2018, 11:04 PM

Btw, upstream just merged all patches. \o/

x11/polybar/pkg-plist
2 ↗(On Diff #40528)

Weird. Now it is being installed in here with %%IPC%% in there. I guess I've missed something while testing it.

Thanks!

rigoletto added a comment.EditedMar 22 2018, 1:00 AM

Unless I understood wrong how that works (HERE and HERE), the IPC module unfortunately seems to be broken.

Adding "enable-ipc = true" to config and creating a simple custom module:

[module/demo]
type = custom/ipc
hook-0 = date
click-left = polybar-msg -p %pid% hook demo 1

and then starting polybar. The FIFO file is created in /tmp and an empty area appear on the specified part of the bar.

The simplest test would be running something like "polybar-msg cmd hide" to hide the bar, but that return "polybar-msg: No process with pid ${pid}".

The second one was a tentative to trigger the hook-0: "echo 'hook:demo/ipc1' >>/tmp/polybar_mqueue.${pid}" and ... notthing happened.

I tried several ways to make it work but the only one that appear to triggered the hook was setting "initial = 1" to make the hook-0 be triggered at the polybar start.

So I guess something is broken between the FIFO and polybar. For course, mouse clicking also does not work.

rigoletto updated this revision to Diff 40577.Mar 22 2018, 1:15 AM

Last fixes.

Thanks.

Harbormaster completed remote builds in B15703: Diff 40577.Mar 22 2018, 1:15 AM
rigoletto updated this revision to Diff 40581.EditedMar 22 2018, 3:08 AM

More broken modules: cpu, ram.

Disabling IPC as it seem to be partially broken. Does not work when using the 'polybar-msg' command.

Harbormaster completed remote builds in B15705: Diff 40581.Mar 22 2018, 3:08 AM
rigoletto edited the summary of this revision. (Show Details)Apr 5 2018, 8:59 PM
rigoletto edited the summary of this revision. (Show Details)Apr 29 2018, 11:39 PM
rigoletto edited the summary of this revision. (Show Details)Apr 29 2018, 11:54 PM
rigoletto updated this revision to Diff 41978.Apr 29 2018, 11:55 PM
rigoletto edited the summary of this revision. (Show Details)

Re-enable IPC and update pkg-message to notice the polybar-msg facility does not
seem to work.

Harbormaster completed remote builds in B16342: Diff 41978.Apr 29 2018, 11:55 PM
rigoletto edited the summary of this revision. (Show Details)Apr 30 2018, 3:06 PM
koobs retitled this revision from x11/polybar: many fixes. to x11/polybar: Many fixes.May 1 2018, 4:09 AM
koobs edited the summary of this revision. (Show Details)
rigoletto retitled this revision from x11/polybar: Many fixes to x11/polybar: many fixes..May 1 2018, 4:11 AM
rigoletto edited the summary of this revision. (Show Details)
rigoletto retitled this revision from x11/polybar: many fixes. to x11/polybar: Many fixes..May 1 2018, 4:26 AM
rigoletto edited the summary of this revision. (Show Details)
rigoletto updated this revision to Diff 42025.May 1 2018, 4:28 AM
rigoletto edited the summary of this revision. (Show Details)

Removing GH_TAGNAME, what was not supposed to be in here.

Thanks.

Harbormaster completed remote builds in B16365: Diff 42025.May 1 2018, 4:28 AM
rigoletto edited the summary of this revision. (Show Details)May 1 2018, 7:03 PM
tobik added inline comments.May 11 2018, 2:08 PM
x11/polybar/Makefile
59

How are the tests run? Does it happen automatically during the build or are you missing TESTS_TEST_TARGET?

rigoletto marked an inline comment as done.May 11 2018, 4:50 PM
rigoletto added inline comments.
x11/polybar/Makefile
59

They are automatic, the instructions are set on the CMakeLists.txt file. Here is another CMakeLists.txt with the option to enable it.

This revision was not accepted when it landed; it landed in state Needs Review.May 12 2018, 7:11 AM
Closed by commit rP469708: x11/polybar: Disable ALSA by default (authored by tobik). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
x11/
polybar/
17 lines
18 lines

Diff 40577

View Options

x11/polybar/Makefile

Loading...
View Options

x11/polybar/pkg-message

Loading...