Fix ISP_FC_LIP and ISP_RESCAN on big-endian 64-bit systems.
ClosedPublic
Actions

Authored by brooks on Mar 12 2018, 9:25 PM.

Details

Reviewers

mav
ken

Commits

rS331635: MFC r330876, r330945
rS331634: MFC r330876, r330945
rS330876: Fix ISP_FC_LIP and ISP_RESCAN on big-endian 64-bit systems.

Summary

For _IO() ioctls, addr is a pointer to uap->data which is a caddr_t.
When the caddr_t stores an int, dereferencing addr as an (int *) results
in truncation on little-endian 64-bit systems and corruption (owing to
extracting top bits) on big-endian 64-bit systems. In practice the
value of chan was probably always zero on systems of the latter type.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15528
Build 15569: arc lint + arc unit

Event Timeline

brooks created this revision.Mar 12 2018, 9:25 PM

Harbormaster completed remote builds in B15528: Diff 40222.Mar 12 2018, 9:25 PM

It makes some sense to me, but I suspect that this code is generally dead, since I don't know any user-space tool using it. Ken, do you?

This revision is now accepted and ready to land.Mar 12 2018, 9:46 PM

brooks retitled this revision from Fix ISP_FC_LIP and ISP_RESCAN on big-endian 64-bit systemss to Fix ISP_FC_LIP and ISP_RESCAN on big-endian 64-bit systems..Mar 12 2018, 11:05 PM

Closed by commit rS330876: Fix ISP_FC_LIP and ISP_RESCAN on big-endian 64-bit systems. (authored by brooks). · Explain WhyMar 13 2018, 7:56 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptMar 13 2018, 7:56 PM