e1000g: this statement may fall through
ClosedPublic
Actions

Authored by tsoome on Mar 12 2018, 5:52 AM.

Details

Reviewers

sbruno
eadler

Commits

rS330803: e1000g: this statement may fall through

Summary

The gcc 7 does check for switch statement fall through cases, and if legit,
such complaint can besilenced by /* FALLTHROUGH */ comment. Unfortunately
such comment is quite limited, but will still notify the reader.

This patch is backport from illumos, see
https://www.illumos.org/rb/r/941/

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15509
Build 15550: arc lint + arc unit

Event Timeline

tsoome created this revision.Mar 12 2018, 5:52 AM

Herald added a reviewer: sbruno. · View Herald TranscriptMar 12 2018, 5:52 AM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B15509: Diff 40187.Mar 12 2018, 5:52 AM

eadler accepted this revision.Mar 12 2018, 5:56 AM

This revision is now accepted and ready to land.Mar 12 2018, 5:56 AM

Closed by commit rS330803: e1000g: this statement may fall through (authored by tsoome). · Explain WhyMar 12 2018, 5:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

e1000/

3 lines

1 line

1 line

2 lines

Diff 40187

View Options

sys/dev/e1000/e1000_82575.c

View Options

sys/dev/e1000/e1000_mbx.c

View Options

sys/dev/e1000/e1000_phy.c

View Options

e1000g: this statement may fall throughClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 40187

sys/dev/e1000/e1000_82575.c

sys/dev/e1000/e1000_mbx.c

sys/dev/e1000/e1000_phy.c

sys/dev/e1000/e1000_vf.c

e1000g: this statement may fall through
ClosedPublic
Actions

Revision Contents
Changeset List