www/chromium: add CUPS option
ClosedPublic
Actions

Authored by leres on Mar 11 2018, 7:48 PM.

Details

Reviewers

ler
matthew

Commits

rP464264: Add a CUPS option to disable cups support and remove the

Summary

Proposed commit message:

Add a CUPS option to disable cups support and remove the
dependency on print/cups. This includes a patch from cpm@
that solves an undefined linker reference that occurs when
cups is disabled. Since chromium does not support printing
without cups enabling this option also disables printing and
print previews. 

PR: 226505
Reviewed by: ?
Approved by: ?
Differential Revision: ?

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 15503
Build 15544: arc lint + arc unit

Event Timeline

leres created this revision.Mar 11 2018, 7:48 PM

Herald added a subscriber: mat. · View Herald TranscriptMar 11 2018, 7:48 PM

Harbormaster completed remote builds in B15503: Diff 40177.Mar 11 2018, 7:48 PM

leres edited the summary of this revision. (Show Details)Mar 11 2018, 7:56 PM

This looks OK, on the face of it, although I'm having some (hopefully temporary) local troubles getting a test build to work.
Are you in contact with the chromium@ developers? According to https://wiki.freebsd.org/Chromium that's rene@freebsd.org or cpm@freebsd.org:
it might be worth adding them as reviewers.