Page MenuHomeFreeBSD

www/chromium: add CUPS option
ClosedPublic

Authored by leres on Mar 11 2018, 7:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 2:53 PM
Unknown Object (File)
Jan 16 2024, 6:13 AM
Unknown Object (File)
Dec 23 2023, 1:26 PM
Unknown Object (File)
Nov 19 2023, 2:25 AM
Unknown Object (File)
Nov 19 2023, 2:19 AM
Unknown Object (File)
Nov 19 2023, 1:57 AM
Unknown Object (File)
Nov 19 2023, 12:57 AM
Unknown Object (File)
Nov 7 2023, 7:12 PM
Subscribers

Details

Summary

Proposed commit message:

Add a CUPS option to disable cups support and remove the
dependency on print/cups. This includes a patch from cpm@
that solves an undefined linker reference that occurs when
cups is disabled. Since chromium does not support printing
without cups enabling this option also disables printing and
print previews. 

PR: 226505
Reviewed by: ?
Approved by: ?
Differential Revision: ?

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 15503
Build 15544: arc lint + arc unit

Event Timeline

This looks OK, on the face of it, although I'm having some (hopefully temporary) local troubles getting a test build to work.
Are you in contact with the chromium@ developers? According to https://wiki.freebsd.org/Chromium that's rene@freebsd.org or cpm@freebsd.org:
it might be worth adding them as reviewers.

Ah -- I see cpm@ has commented on the bugzilla PR. Remember to add him to the Approved by: line when you commit.
lgtm

This revision is now accepted and ready to land.Mar 12 2018, 7:28 AM
This revision was automatically updated to reflect the committed changes.