Page MenuHomeFreeBSD
Differential D14652

Fix build of dspdfviewer on 11.1
ClosedPublic
Actions

Authored by adridg on Mar 11 2018, 1:01 PM.
Tags
None
Referenced Files
F168264217: D14652.id.diff
Thu, Aug 27, 6:37 AM
F168120380: D14652.id.diff
Wed, Aug 26, 11:41 AM
Unknown Object (File)
Tue, Aug 25, 2:33 PM
Unknown Object (File)
Mon, Aug 24, 5:20 PM
Unknown Object (File)
Mon, Aug 24, 12:07 PM
Unknown Object (File)
Mon, Aug 24, 3:17 AM
Unknown Object (File)
Sun, Aug 23, 9:34 PM
Unknown Object (File)
Sun, Aug 23, 2:20 PM
View All Files
Subscribers
mat

Details

Reviewers
tcberner
rakuco
Commits
rP465086: Fix graphics/dspdfviewer build with modern Clang. The error message
Summary

Build fails (while testing update to CMake, unrelated) with:

../hyperlinkarea.cpp:35:18: error: zero as null pointer constant [-Werror,-Wzero-as-null-pointer-constant]

if ( pixmap == 0 )
               ^
               nullptr

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 15494
Build 15536: arc lint + arc unit

Event Timeline

adridg created this revision.Mar 11 2018, 1:01 PM
Herald added a subscriber: mat. · View Herald TranscriptMar 11 2018, 1:01 PM
Harbormaster completed remote builds in B15494: Diff 40163.Mar 11 2018, 1:01 PM
tcberner accepted this revision.Mar 11 2018, 1:43 PM

Looks good to me.

This revision is now accepted and ready to land.Mar 11 2018, 1:43 PM
mat added inline comments.Mar 12 2018, 10:12 AM
graphics/dspdfviewer/files/patch-hyperlinkarea.cpp
14–15

I think it should be == NULL. The problem it tells you is that you are comparing a pointer with an integer.

Closed by commit rP465086: Fix graphics/dspdfviewer build with modern Clang. The error message (authored by adridg). · Explain WhyMar 20 2018, 1:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
graphics/
dspdfviewer/
files/
18 lines

Diff 40163

View Options

graphics/dspdfviewer/files/patch-hyperlinkarea.cpp

Loading...