Page MenuHomeFreeBSD
Differential D12050

Fix mlx5en(4) to properly call m_defrag.
ClosedPublic
Actions

Authored by mjoras on Aug 16 2017, 7:01 PM.
Tags
None
Referenced Files
F137068014: D12050.id32134.diff
Fri, Nov 21, 2:10 AM
F137067838: D12050.id40071.diff
Fri, Nov 21, 2:09 AM
F137067707: D12050.id32138.diff
Fri, Nov 21, 2:09 AM
F137067619: D12050.id.diff
Fri, Nov 21, 2:09 AM
F137066415: D12050.diff
Fri, Nov 21, 2:06 AM
Unknown Object (File)
Wed, Nov 19, 8:50 PM
Unknown Object (File)
Tue, Nov 18, 3:41 AM
Unknown Object (File)
Sun, Nov 2, 2:51 AM
View All Files
Subscribers
ae
imp

Details

Reviewers
• hselasky
gallatin
Commits
rS331589: MFC r330658:
rS330658: Fix mlx5en(4) driver to properly call m_defrag().
Summary

This is essentially the same change as was previously made to mlx4en(4).
By stripping the chain of "empty" mbufs, it was removing M_PKTHDR from
the chain. This stripping is not needed since BUSDMA(9) does not map
empty mbufs.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mjoras created this revision.Aug 16 2017, 7:01 PM
Herald added subscribers: ae, imp. · View Herald TranscriptAug 16 2017, 7:01 PM
• hselasky added inline comments.Aug 16 2017, 7:34 PM
sys/dev/mlx5/mlx5_en/mlx5_en_tx.c
334 ↗(On Diff #32134)

Can you add braces {} around this multi line statement?

mjoras added inline comments.Aug 16 2017, 7:36 PM
sys/dev/mlx5/mlx5_en/mlx5_en_tx.c
334 ↗(On Diff #32134)

Sure, that's my preference as well but I wasn't so sure about the prevailing style for the driver.

mjoras updated this revision to Diff 32138.Aug 16 2017, 7:37 PM
  • braces
Harbormaster completed remote builds in B11114: Diff 32138.Aug 16 2017, 7:37 PM
mjoras marked an inline comment as done.Aug 16 2017, 7:38 PM
• hselasky edited edge metadata.Aug 16 2017, 7:42 PM

This patch looks good to me. @gallatin do you want to test it aswell before it reaches -head? I'll give it a spin tomorrow.

mjoras added a comment.Mar 7 2018, 2:24 AM

Hans, did you ever get a chance to test this?

• hselasky added a comment.Mar 7 2018, 8:52 PM

I'll have a look. I think we have a patch in the upstreaming list which covers this.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 8 2018, 3:53 PM
Closed by commit rS330658: Fix mlx5en(4) driver to properly call m_defrag(). (authored by • hselasky). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
mlx5/
mlx5_en/
30 lines

Diff 40071

View Options

head/sys/dev/mlx5/mlx5_en/mlx5_en_tx.c

Loading...