Page MenuHomeFreeBSD
Differential D14587

Use umtx_copyin_umtx_time32() in __umtx_op_lock_umutex_compat32().
ClosedPublic
Actions

Authored by brooks on Mar 5 2018, 6:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 21, 9:10 AM
Unknown Object (File)
Dec 11 2024, 10:37 PM
Unknown Object (File)
Dec 3 2024, 11:55 PM
Unknown Object (File)
Nov 28 2024, 8:28 PM
Unknown Object (File)
Nov 23 2024, 12:33 AM
Unknown Object (File)
Oct 18 2024, 1:31 PM
Unknown Object (File)
Oct 5 2024, 12:47 AM
Unknown Object (File)
Sep 19 2024, 4:34 PM
View All 39 Files
Subscribers
imp

Details

Reviewers
kib
Commits
rS330678: MFC r330527:
rS330677: MFC r330527:
rS330527: Use umtx_copyin_umtx_time32() in __umtx_op_lock_umutex_compat32().
Summary

This appears to have been a typo. This had no impact because the
underlying implementation returns EINTR if timeout is non-NULL.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15375
Build 15426: arc lint + arc unit

Event Timeline

brooks created this revision.Mar 5 2018, 6:06 PM
Harbormaster completed remote builds in B15375: Diff 39964.Mar 5 2018, 6:06 PM
kib accepted this revision.Mar 5 2018, 6:25 PM

The change is fine, but I do not understand the comment. I suspect that often invalid clock_id is read and ulock compat32 fails.

This revision is now accepted and ready to land.Mar 5 2018, 6:25 PM
brooks added a comment.Mar 6 2018, 1:43 AM
In D14587#306249, @kib wrote:

The change is fine, but I do not understand the comment. I suspect that often invalid clock_id is read and ulock compat32 fails.

You are correct. I misread do_lock_umutex.

Closed by commit rS330527: Use umtx_copyin_umtx_time32() in __umtx_op_lock_umutex_compat32(). (authored by brooks). · Explain WhyMar 6 2018, 1:52 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptMar 6 2018, 1:52 AM

Revision Contents
Changeset List

PathSize
sys/
kern/
2 lines

Diff 39964

View Options

sys/kern/kern_umtx.c

Loading...