Use umtx_copyin_umtx_time32() in __umtx_op_lock_umutex_compat32().
ClosedPublic
Actions

Authored by brooks on Mar 5 2018, 6:06 PM.

Details

Reviewers

Commits

rS330678: MFC r330527:
rS330677: MFC r330527:
rS330527: Use umtx_copyin_umtx_time32() in __umtx_op_lock_umutex_compat32().

Summary

This appears to have been a typo. This had no impact because the
underlying implementation returns EINTR if timeout is non-NULL.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Mar 5 2018, 6:06 PM

Harbormaster completed remote builds in B15375: Diff 39964.Mar 5 2018, 6:06 PM

The change is fine, but I do not understand the comment. I suspect that often invalid clock_id is read and ulock compat32 fails.

This revision is now accepted and ready to land.Mar 5 2018, 6:25 PM

In D14587#306249, @kib wrote:

The change is fine, but I do not understand the comment. I suspect that often invalid clock_id is read and ulock compat32 fails.

You are correct. I misread do_lock_umutex.

Closed by commit rS330527: Use umtx_copyin_umtx_time32() in __umtx_op_lock_umutex_compat32(). (authored by brooks). · Explain WhyMar 6 2018, 1:52 AM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptMar 6 2018, 1:52 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

kern_umtx.c

2 lines

Diff 39986

View Options

Use umtx_copyin_umtx_time32() in __umtx_op_lock_umutex_compat32().ClosedPublicActions