rc.subr: Support loading environmental variables from a file
ClosedPublic
Actions

Authored by feld on Feb 20 2018, 6:27 PM.

Details

Reviewers

Commits

rS334221: rc.subr: Support loading environmental variables from a file

Summary

The ${name}_env is not convenient for setting multiple environmental variables
or variables that may have spaces in the value field. Support loading
environment from a file.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15168
Build 15246: arc lint + arc unit

Event Timeline

feld created this revision.Feb 20 2018, 6:27 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 20 2018, 6:27 PM

Fix re-enabling +a

When the env file is missing it breaks the rc script in a fairly obvious way:

.: cannot open /usr/local/etc/fake.env.file.not.there: No such file or directory

This seems fine to me and extra error handling probably isn't necessary unless someone else can think of another issue I'm overlooking.

krion accepted this revision.May 15 2018, 5:30 PM

This revision is now accepted and ready to land.May 15 2018, 5:30 PM

mat added a subscriber: mat.May 16 2018, 6:36 AM

mat added inline comments.

etc/rc.subr
962	[ -n "$_env_file" ] && [ -r "${_env_file}" ]

Committing with the suggested change by mat.

Closed by commit rS334221: rc.subr: Support loading environmental variables from a file (authored by feld). · Explain WhyMay 25 2018, 7:36 PM

This revision was automatically updated to reflect the committed changes.

0mp mentioned this in D15578: Document ${name}_env_file in the rc.subr manual.May 25 2018, 9:43 PM

Revision Contents
Changeset List

Path

Size

etc/

rc.subr

11 lines

Diff 39537

View Options

rc.subr: Support loading environmental variables from a fileClosedPublicActions