Page MenuHomeFreeBSD
Differential D14419

lua loader: Auto detect eligible list of kernels to boot
ClosedPublic
Actions

Authored by cem on Feb 17 2018, 9:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Aug 3, 10:56 PM
Unknown Object (File)
Mon, Jul 29, 9:44 AM
Unknown Object (File)
Mon, Jul 15, 1:35 AM
Unknown Object (File)
Jul 7 2024, 8:17 AM
Unknown Object (File)
Jun 21 2024, 6:51 AM
Unknown Object (File)
Apr 15 2024, 5:32 AM
Unknown Object (File)
Feb 4 2024, 2:01 AM
Unknown Object (File)
Jan 9 2024, 4:30 AM
View All 20 Files
Subscribers
None

Details

Reviewers
imp
kevans
Commits
rS329501: lua loader: Auto detect eligible list of kernels to boot

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15121
Build 15214: arc lint + arc unit

Event Timeline

cem created this revision.Feb 17 2018, 9:58 PM
Harbormaster completed remote builds in B15121: Diff 39444.Feb 17 2018, 9:58 PM
imp accepted this revision.Feb 17 2018, 10:00 PM

This looks really cool!

stand/lua/core.lua
149

How close / far from the standard lfs definition is this?

This revision is now accepted and ready to land.Feb 17 2018, 10:00 PM
cem added a parent revision: D14418: Lua loader: Add barebones "lfs" module.Feb 17 2018, 10:00 PM
cem added a comment.Feb 17 2018, 10:03 PM
In D14419#302195, @imp wrote:

This looks really cool!

Thanks!

stand/lua/core.lua
149

lfs.dir() is identical, I think.

lfs.attributes() is slightly different in that we don't represent permissions as "drwxrwxrwx" and instead just dump an octal string out. That could be made more compliant if it's important.

(And: we're missing all APIs except those two.)

Otherwise, it should match the standard lfs exactly.

kevans accepted this revision.Feb 17 2018, 10:12 PM

Looks good to me. =) Deduping the kernel listing was on my TODO list, along with fixing the module_path foo.

cem added a comment.Feb 17 2018, 10:21 PM
In D14419#302223, @kevans wrote:

Looks good to me. =) Deduping the kernel listing was on my TODO list, along with fixing the module_path foo.

Thanks! I'm not sure I understand / did anything about module_path foo, can you elaborate a little?

kevans added a comment.Feb 17 2018, 10:28 PM
In D14419#302234, @cem wrote:
In D14419#302223, @kevans wrote:

Looks good to me. =) Deduping the kernel listing was on my TODO list, along with fixing the module_path foo.

Thanks! I'm not sure I understand / did anything about module_path foo, can you elaborate a little?

Nothing you've touched here, but a little further down [1] we add kernel directory to module_path, but we build off of getenv('module_path') and end up with multiple kernel directories in the path. Ideally we'd cache the module_path the first time and add the current kernel path to that every time.

https://svnweb.freebsd.org/base/head/stand/lua/config.lua?revision=329457&view=markup#l296

kevans added a comment.Feb 17 2018, 10:33 PM

(while flipping through the kernel selector, that is)

cem added a comment.Feb 18 2018, 12:34 AM
In D14419#302237, @kevans wrote:

Nothing you've touched here, but a little further down [1] we add kernel directory to module_path, but we build off of getenv('module_path') and end up with multiple kernel directories in the path. Ideally we'd cache the module_path the first time and add the current kernel path to that every time.

https://svnweb.freebsd.org/base/head/stand/lua/config.lua?revision=329457&view=markup#l296

Oh, ok. I'm going to leave that alone in this revision, if that's alright.

Closed by commit rS329501: lua loader: Auto detect eligible list of kernels to boot (authored by cem). · Explain WhyFeb 18 2018, 1:16 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
stand/
lua/
32 lines

Diff 39444

View Options

stand/lua/core.lua

Loading...