lua loader: Auto detect eligible list of kernels to boot

[imp]

This looks really cool!

stand/lua/core.lua

149 ↗

(On Diff #39444)

How close / far from the standard lfs definition is this?

[cem]

In D14419#302195, @imp wrote:

This looks really cool!

Thanks!

stand/lua/core.lua

149 ↗

(On Diff #39444)

lfs.dir() is identical, I think.

lfs.attributes() is slightly different in that we don't represent permissions as "drwxrwxrwx" and instead just dump an octal string out. That could be made more compliant if it's important.

(And: we're missing all APIs except those two.)

Otherwise, it should match the standard lfs exactly.

[kevans]

Looks good to me. =) Deduping the kernel listing was on my TODO list, along with fixing the module_path foo.

[cem]

In D14419#302223, @kevans wrote:

Looks good to me. =) Deduping the kernel listing was on my TODO list, along with fixing the module_path foo.

Thanks! I'm not sure I understand / did anything about module_path foo, can you elaborate a little?

[kevans]

In D14419#302234, @cem wrote:

In D14419#302223, @kevans wrote:

Looks good to me. =) Deduping the kernel listing was on my TODO list, along with fixing the module_path foo.

Thanks! I'm not sure I understand / did anything about module_path foo, can you elaborate a little?

Nothing you've touched here, but a little further down [1] we add kernel directory to module_path, but we build off of getenv('module_path') and end up with multiple kernel directories in the path. Ideally we'd cache the module_path the first time and add the current kernel path to that every time.

https://svnweb.freebsd.org/base/head/stand/lua/config.lua?revision=329457&view=markup#l296

[kevans]

(while flipping through the kernel selector, that is)

[cem]

In D14419#302237, @kevans wrote:

Nothing you've touched here, but a little further down [1] we add kernel directory to module_path, but we build off of getenv('module_path') and end up with multiple kernel directories in the path. Ideally we'd cache the module_path the first time and add the current kernel path to that every time.

https://svnweb.freebsd.org/base/head/stand/lua/config.lua?revision=329457&view=markup#l296

Oh, ok. I'm going to leave that alone in this revision, if that's alright.