style(9)ify boot2.c
ClosedPublic
Actions

Authored by benno on Feb 14 2018, 12:27 AM.

Tags

None

Referenced Files

	F151250577: D14366.id39291.diff
	Tue, Apr 7, 3:07 AM

	Unknown Object (File)
	Sun, Mar 29, 4:25 PM

	Unknown Object (File)
	Tue, Mar 24, 9:14 PM

	Unknown Object (File)
	Tue, Mar 24, 8:49 PM

	Unknown Object (File)
	Tue, Mar 24, 7:28 AM

	Unknown Object (File)
	Wed, Mar 18, 7:09 AM

	Unknown Object (File)
	Mon, Mar 16, 4:57 PM

	Unknown Object (File)
	Sun, Mar 15, 3:15 AM

View All Files

Subscribers

cem

Details

Reviewers

imp

Commits

rS329269: Reformat to come significantly closer to style(9).

Summary

Style fixup for boot2.c.

There's a one code change in parse() so the code fits inside 80 columns.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

benno created this revision.Feb 14 2018, 12:27 AM

So style(9) requires a blank line at the start of a function with no local variables. I tagged a couple, but there are more.

stand/i386/boot2/boot2.c
149	Blank line at start of function rule
189	blank line
351	this, and others, need parse(void)

Added blank lines to the start of functions without variable declarations.
Removed assignments from variable declarations (except one that was static).

lgtm, though I must admit to review fatigue

This revision is now accepted and ready to land.Feb 14 2018, 1:09 AM

Closed by commit rS329269: Reformat to come significantly closer to style(9). (authored by benno). · Explain WhyFeb 14 2018, 6:07 PM

This revision was automatically updated to reflect the committed changes.

In D14366#301004, @imp wrote:

So style(9) requires a blank line at the start of a function with no local variables. I tagged a couple, but there are more.

I think you could remove that clause from style(9) without (much? any?) objection, if you wanted to go through that whole mess to gather consensus.

Revision Contents
Changeset List

Path

Size

stand/

i386/

boot2/

boot2.c

887 lines

Diff 39295

View Options

style(9)ify boot2.cClosedPublicActions