Page MenuHomeFreeBSD

style(9)ify boot2.c
ClosedPublic

Authored by benno on Feb 14 2018, 12:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 6, 3:49 AM
Unknown Object (File)
Feb 15 2024, 1:19 AM
Unknown Object (File)
Nov 8 2023, 10:49 AM
Unknown Object (File)
Nov 7 2023, 12:19 PM
Unknown Object (File)
Nov 7 2023, 9:19 AM
Unknown Object (File)
Nov 4 2023, 6:54 AM
Unknown Object (File)
Nov 1 2023, 1:13 AM
Unknown Object (File)
Oct 7 2023, 9:47 AM
Subscribers

Details

Summary

Style fixup for boot2.c.

There's a one code change in parse() so the code fits inside 80 columns.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 15037

Event Timeline

So style(9) requires a blank line at the start of a function with no local variables. I tagged a couple, but there are more.

stand/i386/boot2/boot2.c
149

Blank line at start of function rule

189

blank line

351

this, and others, need parse(void)

Added blank lines to the start of functions without variable declarations.
Removed assignments from variable declarations (except one that was static).

lgtm, though I must admit to review fatigue

This revision is now accepted and ready to land.Feb 14 2018, 1:09 AM
This revision was automatically updated to reflect the committed changes.
In D14366#301004, @imp wrote:

So style(9) requires a blank line at the start of a function with no local variables. I tagged a couple, but there are more.

I think you could remove that clause from style(9) without (much? any?) objection, if you wanted to go through that whole mess to gather consensus.