style(9)ify boot2.c
ClosedPublic

Authored by benno on Wed, Feb 14, 12:27 AM.

Details

Summary

Style fixup for boot2.c.

There's a one code change in parse() so the code fits inside 80 columns.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
benno created this revision.Wed, Feb 14, 12:27 AM
imp added a comment.Wed, Feb 14, 12:31 AM

So style(9) requires a blank line at the start of a function with no local variables. I tagged a couple, but there are more.

stand/i386/boot2/boot2.c
149 ↗(On Diff #39291)

Blank line at start of function rule

189 ↗(On Diff #39291)

blank line

351 ↗(On Diff #39291)

this, and others, need parse(void)

benno updated this revision to Diff 39295.Wed, Feb 14, 12:38 AM

Added blank lines to the start of functions without variable declarations.
Removed assignments from variable declarations (except one that was static).

imp accepted this revision.Wed, Feb 14, 1:09 AM

lgtm, though I must admit to review fatigue

This revision is now accepted and ready to land.Wed, Feb 14, 1:09 AM
This revision was automatically updated to reflect the committed changes.
cem added a subscriber: cem.Wed, Feb 14, 6:08 PM
In D14366#301004, @imp wrote:

So style(9) requires a blank line at the start of a function with no local variables. I tagged a couple, but there are more.

I think you could remove that clause from style(9) without (much? any?) objection, if you wanted to go through that whole mess to gather consensus.