Page MenuHomeFreeBSD
Differential D14366

style(9)ify boot2.c
ClosedPublic
Actions

Authored by benno on Feb 14 2018, 12:27 AM.
Tags
None
Referenced Files
F164869296: D14366.id39309.diff
Tue, Aug 4, 9:30 AM
F164817464: D14366.id39291.diff
Tue, Aug 4, 4:50 AM
Unknown Object (File)
Mon, Aug 3, 6:19 AM
Unknown Object (File)
Thu, Jul 30, 12:27 PM
Unknown Object (File)
Tue, Jul 28, 9:48 PM
Unknown Object (File)
Sun, Jul 26, 11:12 AM
Unknown Object (File)
Sat, Jul 25, 10:51 PM
Unknown Object (File)
Sat, Jul 25, 3:48 PM
View All Files
Subscribers
cem

Details

Reviewers
imp
Commits
rS329269: Reformat to come significantly closer to style(9).
Summary

Style fixup for boot2.c.

There's a one code change in parse() so the code fits inside 80 columns.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

benno created this revision.Feb 14 2018, 12:27 AM
imp added a comment.Feb 14 2018, 12:31 AM

So style(9) requires a blank line at the start of a function with no local variables. I tagged a couple, but there are more.

stand/i386/boot2/boot2.c
149 ↗(On Diff #39291)

Blank line at start of function rule

189 ↗(On Diff #39291)

blank line

351 ↗(On Diff #39291)

this, and others, need parse(void)

benno updated this revision to Diff 39295.Feb 14 2018, 12:38 AM

Added blank lines to the start of functions without variable declarations.
Removed assignments from variable declarations (except one that was static).

imp accepted this revision.Feb 14 2018, 1:09 AM

lgtm, though I must admit to review fatigue

This revision is now accepted and ready to land.Feb 14 2018, 1:09 AM
Closed by commit rS329269: Reformat to come significantly closer to style(9). (authored by benno). · Explain WhyFeb 14 2018, 6:07 PM
This revision was automatically updated to reflect the committed changes.
cem added a subscriber: cem.Feb 14 2018, 6:08 PM
In D14366#301004, @imp wrote:

So style(9) requires a blank line at the start of a function with no local variables. I tagged a couple, but there are more.

I think you could remove that clause from style(9) without (much? any?) objection, if you wanted to go through that whole mess to gather consensus.

Revision Contents
Changeset List

PathSize
head/
stand/
i386/
boot2/
859 lines

Diff 39309

View Options

head/stand/i386/boot2/boot2.c

Loading...