Page MenuHomeFreeBSD

style(9)ify boot2.c
ClosedPublic

Authored by benno on Feb 14 2018, 12:27 AM.
Tags
None
Referenced Files
F175540703: D14366.id39295.diff
Sun, Oct 11, 2:16 PM
F175539843: D14366.id39291.diff
Sun, Oct 11, 2:08 PM
F175539818: D14366.id.diff
Sun, Oct 11, 2:07 PM
F175539810: D14366.id39295.diff
Sun, Oct 11, 2:07 PM
F175539806: D14366.diff
Sun, Oct 11, 2:07 PM
F175539786: D14366.id39309.diff
Sun, Oct 11, 2:07 PM
F175525793: D14366.id.diff
Sun, Oct 11, 11:28 AM
Unknown Object (File)
Sat, Oct 10, 1:34 PM
Subscribers

Details

Summary

Style fixup for boot2.c.

There's a one code change in parse() so the code fits inside 80 columns.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

So style(9) requires a blank line at the start of a function with no local variables. I tagged a couple, but there are more.

stand/i386/boot2/boot2.c
149 ↗(On Diff #39291)

Blank line at start of function rule

189 ↗(On Diff #39291)

blank line

351 ↗(On Diff #39291)

this, and others, need parse(void)

Added blank lines to the start of functions without variable declarations.
Removed assignments from variable declarations (except one that was static).

lgtm, though I must admit to review fatigue

This revision is now accepted and ready to land.Feb 14 2018, 1:09 AM
This revision was automatically updated to reflect the committed changes.
In D14366#301004, @imp wrote:

So style(9) requires a blank line at the start of a function with no local variables. I tagged a couple, but there are more.

I think you could remove that clause from style(9) without (much? any?) objection, if you wanted to go through that whole mess to gather consensus.