Differential D14366

style(9)ify boot2.c
ClosedPublic
Actions

Authored by benno on Feb 14 2018, 12:27 AM.

Details

Reviewers

imp

Commits

rS329269: Reformat to come significantly closer to style(9).

Summary

Style fixup for boot2.c.

There's a one code change in parse() so the code fits inside 80 columns.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

benno created this revision.Feb 14 2018, 12:27 AM

So style(9) requires a blank line at the start of a function with no local variables. I tagged a couple, but there are more.

stand/i386/boot2/boot2.c
149 ↗	(On Diff #39291)	Blank line at start of function rule
189 ↗	(On Diff #39291)	blank line
351 ↗	(On Diff #39291)	this, and others, need parse(void)

Added blank lines to the start of functions without variable declarations.
Removed assignments from variable declarations (except one that was static).

lgtm, though I must admit to review fatigue

This revision is now accepted and ready to land.Feb 14 2018, 1:09 AM

Closed by commit rS329269: Reformat to come significantly closer to style(9). (authored by benno). · Explain WhyFeb 14 2018, 6:07 PM

This revision was automatically updated to reflect the committed changes.

In D14366#301004, @imp wrote:

So style(9) requires a blank line at the start of a function with no local variables. I tagged a couple, but there are more.

I think you could remove that clause from style(9) without (much? any?) objection, if you wanted to go through that whole mess to gather consensus.

Revision Contents
Changeset List

Path

Size

head/

stand/

i386/

boot2/

boot2.c

859 lines

Diff 39309

View Options

head/stand/i386/boot2/boot2.c

style(9)ify boot2.cClosedPublicActions