Use syscall_helper_register() to register syscalls and do it through the module interface rather than sysinit.
ClosedPublic
Actions

Authored by brooks on Feb 7 2018, 7:43 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Sep 30, 11:12 PM

	Unknown Object (File)
	Wed, Sep 30, 11:11 PM

	Unknown Object (File)
	Wed, Sep 30, 11:10 PM

	Unknown Object (File)
	Wed, Sep 30, 9:22 PM

	Unknown Object (File)
	Wed, Sep 30, 6:42 AM

	Unknown Object (File)
	Tue, Sep 15, 11:05 PM

	Unknown Object (File)
	Thu, Sep 10, 3:21 AM

	Unknown Object (File)
	Mon, Sep 7, 5:06 AM

View All Files

Subscribers

imp

Details

Reviewers

jhb
rmacklem

Commits

rS329097: Use syscall_helper_register() to register syscalls and initialize though

Summary

This pattern is more common and easier to understand.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Feb 7 2018, 7:43 PM

Looks ok to me, although, since I know nothing about the interface,
I've taken myself off the review.

jhb added inline comments.Feb 8 2018, 7:32 PM

sys/nlm/nlm_prot_impl.c
2404 ↗	(On Diff #39019)	I think you should actually do the nlm_uninit in MOD_UNLOAD case (modules get MOD_UNLOAD invoked if MOD_LOAD fails). It's fine to have that still fallthrough though.

Let MOD_UNLOAD handle the failure case.

jhb accepted this revision.Feb 9 2018, 5:55 PM

This revision is now accepted and ready to land.Feb 9 2018, 5:55 PM

Closed by commit rS329097: Use syscall_helper_register() to register syscalls and initialize though (authored by brooks). · Explain WhyFeb 10 2018, 1:09 AM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptFeb 10 2018, 1:09 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

nlm/

nlm_prot_impl.c

37 lines

Diff 39122

View Options

head/sys/nlm/nlm_prot_impl.c

Use syscall_helper_register() to register syscalls and do it through the module interface rather than sysinit.ClosedPublicActions