Page MenuHomeFreeBSD
Differential D14251

Use syscall_helper_register() to register syscalls and do it through the module interface rather than sysinit.
ClosedPublic
Actions

Authored by brooks on Feb 7 2018, 7:43 PM.
Tags
None
Referenced Files
F103786708: D14251.id39057.diff
Fri, Nov 29, 10:34 AM
Unknown Object (File)
Fri, Nov 15, 6:25 AM
Unknown Object (File)
Oct 28 2024, 8:10 PM
Unknown Object (File)
Oct 21 2024, 11:47 PM
Unknown Object (File)
Oct 19 2024, 4:09 AM
Unknown Object (File)
Oct 18 2024, 11:13 PM
Unknown Object (File)
Oct 18 2024, 9:59 AM
Unknown Object (File)
Oct 5 2024, 12:39 PM
View All 55 Files
Subscribers
imp

Details

Reviewers
jhb
rmacklem
Commits
rS329097: Use syscall_helper_register() to register syscalls and initialize though
Summary

This pattern is more common and easier to understand.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks created this revision.Feb 7 2018, 7:43 PM
rmacklem resigned from this revision.Feb 7 2018, 9:32 PM

Looks ok to me, although, since I know nothing about the interface,
I've taken myself off the review.

jhb added inline comments.Feb 8 2018, 7:32 PM
sys/nlm/nlm_prot_impl.c
2404 ↗(On Diff #39019)

I think you should actually do the nlm_uninit in MOD_UNLOAD case (modules get MOD_UNLOAD invoked if MOD_LOAD fails). It's fine to have that still fallthrough though.

brooks updated this revision to Diff 39057.Feb 8 2018, 8:03 PM
  • Let MOD_UNLOAD handle the failure case.
jhb accepted this revision.Feb 9 2018, 5:55 PM
This revision is now accepted and ready to land.Feb 9 2018, 5:55 PM
Closed by commit rS329097: Use syscall_helper_register() to register syscalls and initialize though (authored by brooks). · Explain WhyFeb 10 2018, 1:09 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptFeb 10 2018, 1:09 AM

Revision Contents
Changeset List

PathSize
head/
sys/
nlm/
37 lines

Diff 39122

View Options

head/sys/nlm/nlm_prot_impl.c

Loading...