fixed amd type flash write opration and diaplay chip infomation at boot
ClosedPublic
Actions

Authored by yamori813_yahoo.co.jp on Feb 9 2018, 4:33 AM.

Details

Reviewers

adrian
mizhka
imp
sbruno

Commits

rS345464: Fix AMD type flash write operations, and display chip information at boot

Summary

amd type flash that is mx chip can't update correctly.
This is fixed by datasheet method.

Test Plan

AR9132 with AMD chip and RT3050 with MX chip
write data by dd command then read data check md5 value.

cfi0: Manufacturer ID:1 Device ID:227e
cfi0: Manufacturer ID:c2 Device ID:22a8

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14893
Build 15005: arc lint + arc unit

Event Timeline

yamori813_yahoo.co.jp created this revision.Feb 9 2018, 4:33 AM

fixed typo

Current code is very dangerous because of doing sector erase to address 0. 0 is boot sector in mips. Almost system is sector 0 is protected then no effect. I see Juniper not tested this code on AMD type flash.

imp added a subscriber: imp.Mar 18 2018, 5:39 PM

imp added inline comments.

sys/dev/cfi/cfi_core.c
513	This should be a bool function. It returns true/false over whether the erase succeeded / failed.
810	why are we doing the read-back with interrupts enabled?