Emit a deprecation warning when mounting a device to print statisistics.
ClosedPublic
Actions

Authored by brooks on Dec 14 2016, 10:43 PM.

Details

Reviewers

cem

Commits

rS329530: MFC r329092:
rS329092: Add a deprecation warning when using the feature which mounts devices

Summary

While this feature is long standing, it is undocumented, fails to
follow the unix philosophy, and is easily scripted.

The warning will be merged to FreeBSD 11 along with recent improvemnts
and the feature will be removed from HEAD before FreeBSD 12.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14888
Build 15000: arc lint + arc unit

Event Timeline

brooks updated this revision to Diff 22934.Dec 14 2016, 10:43 PM

brooks retitled this revision from to Emit a deprecation warning when mounting a device to print statisistics..

brooks updated this object.

brooks edited the test plan for this revision. (Show Details)

brooks added a reviewer: cem.

cem added inline comments.Dec 14 2016, 10:48 PM

bin/df/df.c
276	Why not move this much earlier after `if (S_ISCHR())`?

Move the warning earlier and use xo_warnx().

LGTM, however, this made me realize that the #ifdef MOUNT_CHAR_DEVS is actually in the wrong place (I think).

If (mntpt = getmntpt(*argv)) != NULL, the device is already mounted and we fall out the bottom and stat normally. So the #ifdef should only cover the == NULL part. (I think the #endif may actually be in the right place, just the #if is misplaced.)

This revision is now accepted and ready to land.Dec 14 2016, 10:58 PM

Correct the location of MOUNT_CHAR_DEVS and emit better errors.

This revision now requires review to proceed.Feb 8 2018, 10:40 PM

Harbormaster completed remote builds in B14888: Diff 39071.Feb 8 2018, 10:40 PM

I hate to see more libxo enter programs, but the functional change looks good.

This revision is now accepted and ready to land.Feb 9 2018, 4:38 AM

Closed by commit rS329092: Add a deprecation warning when using the feature which mounts devices (authored by brooks). · Explain WhyFeb 10 2018, 12:22 AM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptFeb 10 2018, 12:22 AM

I reported on this deprecated element core dumping ( https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237368 )

As it was scheduled to be removed before 12 away, maybe it could be actioned now?

Cheers