Use syscall_helper_register() to register syscalls and do it through the module interface rather than sysinit.
ClosedPublic
Actions

Authored by brooks on Feb 7 2018, 7:43 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jul 1, 4:04 PM

	Unknown Object (File)
	Mar 27 2024, 1:35 PM

	Unknown Object (File)
	Mar 14 2024, 10:46 AM

	Unknown Object (File)
	Mar 14 2024, 10:46 AM

	Unknown Object (File)
	Mar 14 2024, 10:46 AM

	Unknown Object (File)
	Mar 14 2024, 10:46 AM

	Unknown Object (File)
	Mar 10 2024, 11:57 PM

	Unknown Object (File)
	Mar 7 2024, 6:18 PM

View All 33 Files

Subscribers

imp

Details

Reviewers

jhb
rmacklem

Commits

rS329097: Use syscall_helper_register() to register syscalls and initialize though

Summary

This pattern is more common and easier to understand.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14856
Build 14970: arc lint + arc unit

Event Timeline

brooks created this revision.Feb 7 2018, 7:43 PM

Looks ok to me, although, since I know nothing about the interface,
I've taken myself off the review.

jhb added inline comments.Feb 8 2018, 7:32 PM

sys/nlm/nlm_prot_impl.c
2404	I think you should actually do the nlm_uninit in MOD_UNLOAD case (modules get MOD_UNLOAD invoked if MOD_LOAD fails). It's fine to have that still fallthrough though.

Let MOD_UNLOAD handle the failure case.

jhb accepted this revision.Feb 9 2018, 5:55 PM

This revision is now accepted and ready to land.Feb 9 2018, 5:55 PM

Closed by commit rS329097: Use syscall_helper_register() to register syscalls and initialize though (authored by brooks). · Explain WhyFeb 10 2018, 1:09 AM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptFeb 10 2018, 1:09 AM

Revision Contents
Changeset List

Path

Size

sys/

nlm/

nlm_prot_impl.c

39 lines

Diff 39019

View Options

Use syscall_helper_register() to register syscalls and do it through the module interface rather than sysinit.ClosedPublicActions