Page MenuHomeFreeBSD

New port: x11-themes/arc-gruvbox-theme
ClosedPublic

Authored by jonathan on Jan 30 2018, 6:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 12, 7:38 PM
Unknown Object (File)
Thu, Mar 12, 11:56 AM
Unknown Object (File)
Wed, Mar 11, 9:58 AM
Unknown Object (File)
Sun, Mar 8, 10:37 PM
Unknown Object (File)
Sun, Mar 8, 4:14 PM
Unknown Object (File)
Sun, Mar 8, 11:22 AM
Unknown Object (File)
Sat, Mar 7, 10:22 PM
Unknown Object (File)
Sat, Feb 28, 10:39 PM
Subscribers

Details

Summary

Gruvbox variation of an Arc Black fork

WWW: https://github.com/Benoth/arc-variations

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 14699
Build 14822: arc lint + arc unit

Event Timeline

mat added inline comments.
x11-themes/arc-gruvbox-theme/Makefile
5

Never use a commit hash here, they are unpredictable.

Use gyyyymmdd using the date of the commit: Example 5.13. Using USE_GITHUB When Upstream Does Not Use Versions.

22–23

NO_BUILD=yes

jonathan marked 2 inline comments as done.
  • Clean up as per review comments.

Looks good. Note that by "date of the commit" I meant date of the commit you reference in GH_TAGNAME, not the date you will commit it in the FreeBSD ports tree. Here, it seems the date is 2016-12-21.

This revision is now accepted and ready to land.Jan 31 2018, 2:20 PM
This revision was automatically updated to reflect the committed changes.