Honor STRIP for rubygems with C extensions
AbandonedPublic
Actions

Authored by asomers on Jan 30 2018, 9:04 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	May 4 2024, 1:13 PM

	Unknown Object (File)
	Apr 22 2024, 8:52 AM

	Unknown Object (File)
	Apr 14 2024, 5:27 PM

	Unknown Object (File)
	Jan 28 2024, 12:50 AM

	Unknown Object (File)
	Jan 16 2024, 5:13 PM

	Unknown Object (File)
	Dec 22 2023, 3:53 AM

	Unknown Object (File)
	Dec 20 2023, 8:26 AM

	Unknown Object (File)
	Dec 6 2023, 12:59 PM

View All 12 Files

Subscribers

antoine

mat

Details

Reviewers

swills

Group Reviewers

O5: Ports Framework	(Owns No Changed Paths)
portmgr

Summary

Honor STRIP for rubygems with C extensions

Ports should not strip rubygems' C extensions when STRIP=0

Test Plan

build devel/rubygem-json with STRIP=0 and with STRIP undefined. In the
former case, the .so files should not be stripped. In the latter case, they
should be.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 14682
Build 14809: arc lint + arc unit

Event Timeline

asomers created this revision.Jan 30 2018, 9:04 PM

Harbormaster completed remote builds in B14682: Diff 38688.Jan 30 2018, 9:04 PM

Owners added a reviewer: O5: Ports Framework.Jan 30 2018, 9:04 PM

Herald added a reviewer: portmgr. · View Herald TranscriptJan 30 2018, 9:04 PM

Herald added a reviewer: portmgr. · View Herald Transcript

Herald added a subscriber: mat. · View Herald Transcript

You should use WITH_DEBUG or WITH_DEBUG _PORTS which will do the right thing.

So is it not supported for users to define STRIP in make.conf?

I don't think so. The documented way is to use WITH_DEBUG or WITH_DEBUG_PORTS.

Ok, will do.

Revision Contents
Changeset List

Path

Size

Mk/

Uses/

gem.mk

2 lines

Diff 38688

View Options

Honor STRIP for rubygems with C extensionsAbandonedPublicActions