Split crp_buf into a union.
ClosedPublic
Actions

Authored by jhb on Jan 16 2018, 12:55 AM.

Tags

None

Referenced Files

	F175185385: D13927.id38053.diff
	Thu, Oct 8, 10:47 PM

	F175185361: D13927.id38020.diff
	Thu, Oct 8, 10:47 PM

	F175177578: D13927.diff
	Thu, Oct 8, 9:44 PM

	Unknown Object (File)
	Tue, Sep 22, 7:46 AM

	Unknown Object (File)
	Fri, Sep 11, 6:01 AM

	Unknown Object (File)
	Sep 6 2026, 2:00 PM

	Unknown Object (File)
	Sep 6 2026, 3:39 AM

	Unknown Object (File)
	Sep 6 2026, 2:30 AM

View All Files

Subscribers

imp

Details

Reviewers

kib
jmg

Commits

rS328057: Split crp_buf into a union.

Summary

This adds explicit crp_mbuf and crp_uio pointers of the right type to
replace casts of crp_buf. This does not sweep through changing existing
code, but new code should use the correct fields instead of casts.

Test Plan

tested with cryptocheck and the in-tree cryptotest tests against cryptosoft, aesni0, and ccr0

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jan 16 2018, 12:55 AM

As a note, anonymous union member is only in C11, for C99 this is a gnu extension.

This revision is now accepted and ready to land.Jan 16 2018, 3:23 PM

Yes, though we already use anonymous unions in the tree now (e.g. struct mbuf uses them).

Closed by commit rS328057: Split crp_buf into a union. (authored by jhb). · Explain WhyJan 16 2018, 7:41 PM

This revision was automatically updated to reflect the committed changes.

Herald added a reviewer: jmg. · View Herald TranscriptJan 16 2018, 7:41 PM

Herald added a subscriber: imp. · View Herald Transcript

Revision Contents
Changeset List

Path

Size

head/

sys/

opencrypto/

cryptodev.h

7 lines

Diff 38053

View Options

head/sys/opencrypto/cryptodev.h

Split crp_buf into a union.ClosedPublicActions