Check the return value from utf8_to_ucs2 instead of whether or not uv is NULL. That's more correct and doesn't depend on the error behavior of utf8_to_ucs2. In practice, we'll never see this though since we pass utf8_to_ucs2 a well formed string.
ClosedPublic
Actions

Authored by imp on Jan 15 2018, 5:03 PM.

Tags

None

Referenced Files

	F172359061: D13918.diff
	Thu, Sep 17, 10:53 PM

	Unknown Object (File)
	Sat, Sep 5, 3:51 PM

	Unknown Object (File)
	Sat, Sep 5, 2:50 PM

	Unknown Object (File)
	Sat, Sep 5, 3:30 AM

	Unknown Object (File)
	Fri, Sep 4, 12:14 PM

	Unknown Object (File)
	Fri, Sep 4, 7:48 AM

	Unknown Object (File)
	Wed, Sep 2, 10:45 PM

	Unknown Object (File)
	Wed, Sep 2, 8:10 AM

View All Files

Subscribers

None

Details

Reviewers

andrew
tsoome

Commits

rS328030: Check the return value from utf8_to_ucs2 instead of whether or not uv

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14385
Build 14539: arc lint + arc unit

Event Timeline

imp created this revision.Jan 15 2018, 5:03 PM

Harbormaster completed remote builds in B14385: Diff 37976.Jan 15 2018, 5:03 PM

imp added reviewers: andrew, tsoome.Jan 15 2018, 5:03 PM

tsoome added inline comments.Jan 15 2018, 7:58 PM

stand/efi/boot1/boot1.c
105	If we check the return value below, we do not need to set NULL here, except if the compiler will trigger may be used uninitialized warning...

imp added inline comments.Jan 15 2018, 10:09 PM

stand/efi/boot1/boot1.c
105	We do, because we want utf8_to_ucs2 to allocate space.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 15 2018, 10:17 PM

Closed by commit rS328030: Check the return value from utf8_to_ucs2 instead of whether or not uv (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

stand/

efi/

boot1/

boot1.c

3 lines

Diff 37976

View Options

Check the return value from utf8_to_ucs2 instead of whether or not uv is NULL. That's more correct and doesn't depend on the error behavior of utf8_to_ucs2. In practice, we'll never see this though since we pass utf8_to_ucs2 a well formed string.ClosedPublicActions