Page MenuHomeFreeBSD

Check the return value from utf8_to_ucs2 instead of whether or not uv is NULL. That's more correct and doesn't depend on the error behavior of utf8_to_ucs2. In practice, we'll never see this though since we pass utf8_to_ucs2 a well formed string.
ClosedPublic

Authored by imp on Jan 15 2018, 5:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 27, 10:50 PM
Unknown Object (File)
Wed, Nov 27, 5:53 AM
Unknown Object (File)
Sun, Nov 24, 11:42 AM
Unknown Object (File)
Nov 16 2024, 10:06 PM
Unknown Object (File)
Nov 11 2024, 2:21 AM
Unknown Object (File)
Nov 11 2024, 1:54 AM
Unknown Object (File)
Nov 11 2024, 12:58 AM
Unknown Object (File)
Nov 11 2024, 12:42 AM
Subscribers
None

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14385
Build 14539: arc lint + arc unit

Event Timeline

stand/efi/boot1/boot1.c
105

If we check the return value below, we do not need to set NULL here, except if the compiler will trigger may be used uninitialized warning...

stand/efi/boot1/boot1.c
105

We do, because we want utf8_to_ucs2 to allocate space.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 15 2018, 10:17 PM
This revision was automatically updated to reflect the committed changes.