Page MenuHomeFreeBSD
Differential D13912

New port: devel/easyloggingpp: C++ logging library
ClosedPublic
Actions

Authored by yuri on Jan 15 2018, 3:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 21 2024, 10:10 PM
Unknown Object (File)
Apr 13 2024, 9:38 PM
Unknown Object (File)
Apr 12 2024, 9:04 PM
Unknown Object (File)
Apr 10 2024, 8:40 PM
Unknown Object (File)
Jan 31 2024, 1:43 PM
Unknown Object (File)
Jan 3 2024, 3:46 AM
Unknown Object (File)
Jan 2 2024, 6:20 PM
Unknown Object (File)
Dec 26 2023, 5:55 PM
View All 32 Files
Subscribers
mat

Details

Reviewers
tcberner
adamw
mat
Commits
rP460067: New port: devel/easyloggingpp: C++ logging library
Summary

C++ logging library

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 14374
Build 14529: arc lint + arc unit

Event Timeline

yuri created this revision.Jan 15 2018, 3:19 AM
Herald added a subscriber: mat. · View Herald TranscriptJan 15 2018, 3:19 AM
Harbormaster completed remote builds in B14374: Diff 37955.Jan 15 2018, 3:19 AM
yuri updated this revision to Diff 37956.Jan 15 2018, 3:20 AM

.

yuri updated this revision to Diff 37957.Jan 15 2018, 3:24 AM

.

tcberner requested changes to this revision.Jan 15 2018, 1:06 PM
tcberner added inline comments.
devel/easyloggingpp/Makefile
17

CMAKE_ON=build_shared_lib

This revision now requires changes to proceed.Jan 15 2018, 1:06 PM
mat requested changes to this revision.Jan 15 2018, 2:56 PM
mat added inline comments.
devel/easyloggingpp/Makefile
7

USE_GITHUB.

yuri updated this revision to Diff 38017.Jan 16 2018, 12:12 AM
yuri marked 2 inline comments as done.

.

Harbormaster completed remote builds in B14403: Diff 38017.Jan 16 2018, 12:12 AM
tcberner accepted this revision.Jan 19 2018, 9:16 AM
yuri added a comment.Jan 26 2018, 11:58 PM

How to unblock this? It uses USE_GITHUB now.

adamw added a comment.Jan 27 2018, 12:08 AM

Ah is the rejection from @mat from before blocking committing?

yuri added a comment.EditedJan 27 2018, 12:12 AM
In D13912#295422, @adamw wrote:

Ah is the rejection from @mat from before blocking committing?

I just didn't want to commit against the "blocking" sign from mat. Should I commit?

adamw accepted this revision.Jan 27 2018, 12:15 AM

Yup I think you're good to go. You addressed all of mat's items and it looks good to me!

yuri added a comment.Jan 27 2018, 12:23 AM
In D13912#295424, @adamw wrote:

Yup I think you're good to go. You addressed all of mat's items and it looks good to me!

Thanks!

yuri retitled this revision from devel/easyloggingpp: C++ logging library to New port: devel/easyloggingpp: C++ logging library.Jan 27 2018, 12:40 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 27 2018, 12:43 AM
Closed by commit rP460067: New port: devel/easyloggingpp: C++ logging library (authored by yuri). · Explain Why
This revision was automatically updated to reflect the committed changes.
yuri mentioned this in rP460067: New port: devel/easyloggingpp: C++ logging library.

Revision Contents
Changeset List

PathSize
devel/
1 line
22 lines
3 lines
32 lines
7 lines

Diff 37955

View Options

devel/Makefile

Loading...
View Options

devel/easyloggingpp/

Loading...
View Options

devel/easyloggingpp/Makefile

Loading...
View Options

devel/easyloggingpp/distinfo

Loading...
View Options

devel/easyloggingpp/files/

Loading...
View Options

devel/easyloggingpp/files/patch-CMakeLists.txt

Loading...
View Options

devel/easyloggingpp/pkg-descr

Loading...