Page MenuHomeFreeBSD
Differential D13912

New port: devel/easyloggingpp: C++ logging library
ClosedPublic
Actions

Authored by yuri on Jan 15 2018, 3:19 AM.
Tags
None
Referenced Files
F158513308: D13912.id37955.diff
Tue, Jun 2, 1:55 PM
F158513295: D13912.id37955.diff
Tue, Jun 2, 1:55 PM
Unknown Object (File)
Mon, Jun 1, 10:10 PM
Unknown Object (File)
Fri, May 8, 3:10 PM
Unknown Object (File)
Thu, May 7, 12:38 PM
Unknown Object (File)
Thu, May 7, 8:31 AM
Unknown Object (File)
Thu, May 7, 7:00 AM
Unknown Object (File)
Tue, May 5, 2:28 PM
View All Files
Subscribers
mat

Details

Reviewers
tcberner
adamw
mat
Commits
rP460067: New port: devel/easyloggingpp: C++ logging library
Summary

C++ logging library

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

yuri created this revision.Jan 15 2018, 3:19 AM
Herald added a subscriber: mat. · View Herald TranscriptJan 15 2018, 3:19 AM
Harbormaster completed remote builds in B14374: Diff 37955.Jan 15 2018, 3:19 AM
yuri updated this revision to Diff 37956.Jan 15 2018, 3:20 AM

.

yuri updated this revision to Diff 37957.Jan 15 2018, 3:24 AM

.

tcberner requested changes to this revision.Jan 15 2018, 1:06 PM
tcberner added inline comments.
devel/easyloggingpp/Makefile
16 ↗(On Diff #37957)

CMAKE_ON=build_shared_lib

This revision now requires changes to proceed.Jan 15 2018, 1:06 PM
mat requested changes to this revision.Jan 15 2018, 2:56 PM
mat added inline comments.
devel/easyloggingpp/Makefile
6 ↗(On Diff #37957)

USE_GITHUB.

yuri updated this revision to Diff 38017.Jan 16 2018, 12:12 AM
yuri marked 2 inline comments as done.

.

Harbormaster completed remote builds in B14403: Diff 38017.Jan 16 2018, 12:12 AM
tcberner accepted this revision.Jan 19 2018, 9:16 AM
yuri added a comment.Jan 26 2018, 11:58 PM

How to unblock this? It uses USE_GITHUB now.

adamw added a comment.Jan 27 2018, 12:08 AM

Ah is the rejection from @mat from before blocking committing?

yuri added a comment.EditedJan 27 2018, 12:12 AM
In D13912#295422, @adamw wrote:

Ah is the rejection from @mat from before blocking committing?

I just didn't want to commit against the "blocking" sign from mat. Should I commit?

adamw accepted this revision.Jan 27 2018, 12:15 AM

Yup I think you're good to go. You addressed all of mat's items and it looks good to me!

yuri added a comment.Jan 27 2018, 12:23 AM
In D13912#295424, @adamw wrote:

Yup I think you're good to go. You addressed all of mat's items and it looks good to me!

Thanks!

yuri retitled this revision from devel/easyloggingpp: C++ logging library to New port: devel/easyloggingpp: C++ logging library.Jan 27 2018, 12:40 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 27 2018, 12:43 AM
Closed by commit rP460067: New port: devel/easyloggingpp: C++ logging library (authored by yuri). · Explain Why
This revision was automatically updated to reflect the committed changes.
yuri mentioned this in rP460067: New port: devel/easyloggingpp: C++ logging library.

Revision Contents
Changeset List

PathSize
head/
devel/
1 line
easyloggingpp/
24 lines
3 lines
files/
34 lines
7 lines

Diff 38508

View Options

head/devel/Makefile

Loading...
View Options

head/devel/easyloggingpp/Makefile

Loading...
View Options

head/devel/easyloggingpp/distinfo

Loading...
View Options

head/devel/easyloggingpp/files/patch-CMakeLists.txt

Loading...
View Options

head/devel/easyloggingpp/pkg-descr

Loading...