Page MenuHomeFreeBSD
Differential D13794

audio/carla: Update to 1.9.7b-372
ClosedPublic
Actions

Authored by yuri on Jan 8 2018, 10:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 4, 3:46 PM
Unknown Object (File)
Feb 26 2024, 7:33 AM
Unknown Object (File)
Jan 23 2024, 10:38 AM
Unknown Object (File)
Jan 15 2024, 3:55 PM
Unknown Object (File)
Dec 24 2023, 3:45 AM
Unknown Object (File)
Dec 21 2023, 6:06 AM
Unknown Object (File)
Dec 20 2023, 8:35 AM
Unknown Object (File)
Dec 2 2023, 10:15 AM
View All 28 Files
Subscribers
mat

Details

Reviewers
tcberner
adamw
Commits
rP460074: audio/carla: Update to 1.9.8
Summary

The user contacted me and said that py-sip dependency was missing.
Changes:

  • Added the py-sip dependency (thanks to the user, Goran Mekić <meka@tilda.center>, for notifying me)
  • Added USES=shebangfix because it is needed now
  • Added CONFLICTS_BUILD=rtaudio-* rtmidi-* because it is bundled with incompatible versions of both packages and the build picks the preinstalled headers/libs first
Test Plan

Tested Carla, it seems to work with both audio and midi signals.
It still freezes on close, upstream knows this.
The upstream author, falkTX, also promised to independently retest on FreeBSD.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 14244
Build 14407: arc lint + arc unit

Event Timeline

yuri created this revision.Jan 8 2018, 10:20 AM
Herald added a subscriber: mat. · View Herald TranscriptJan 8 2018, 10:20 AM
yuri edited the summary of this revision. (Show Details)Jan 8 2018, 10:26 AM
yuri edited the test plan for this revision. (Show Details)
yuri updated this revision to Diff 37626.Jan 8 2018, 10:30 AM
yuri edited the summary of this revision. (Show Details)

.

Harbormaster completed remote builds in B14180: Diff 37626.Jan 8 2018, 10:30 AM
yuri edited the summary of this revision. (Show Details)Jan 8 2018, 10:31 AM
yuri edited the summary of this revision. (Show Details)
yuri edited the summary of this revision. (Show Details)
yuri edited the summary of this revision. (Show Details)Jan 8 2018, 10:41 AM
tcberner requested changes to this revision.Jan 8 2018, 6:23 PM
tcberner added inline comments.
audio/carla/Makefile
17

^USE_PYQT=sip_build

This revision now requires changes to proceed.Jan 8 2018, 6:23 PM
yuri marked an inline comment as done.Jan 8 2018, 6:52 PM
yuri added inline comments.
audio/carla/Makefile
17

py-sip description reads like it should be a build-time dependency.
However, carla fails without it installed.

The failure occurs in this line:

from PyQt5.QtCore import qCritical, QFileInfo, QModelIndex, QPointF, QTimer

Traceback (most recent call last):
  File "/usr/local/share/carla/carla", line 22, in <module>
    from carla_host import *
  File "/usr/local/share/carla/carla_host.py", line 30, in <module>
    from PyQt5.QtCore import qCritical, QFileInfo, QModelIndex, QPointF, QTimer
ModuleNotFoundError: No module named 'sip'

So far, this looks like a bug in PyQt5 to me.

And I do understand that py-sip is not supposed to be in RUN_DEPENDS.

Now this case needs to either be suspended until the investigation is finished.
Or it should be committed like this with a comment about this problem.

Personally, I would prefer the latter for the reason that having a newer version might improve user experience, and this IMO should be preferred over having one questionable dependency for a while.

yuri marked 2 inline comments as done.Jan 8 2018, 6:53 PM
tcberner added a comment.Jan 8 2018, 7:02 PM

Then make it USE_PYQT=sip_run :)

yuri added a comment.Jan 8 2018, 7:07 PM
In D13794#289076, @tcberner wrote:

Then make it USE_PYQT=sip_run :)

It must be required during build too, so it should be USE_PYQT=sip.
It looks to me that the bug only induces the run dependency, but the build dependency is correct.

tcberner added a comment.Jan 8 2018, 7:11 PM
In D13794#289081, @yuri wrote:
In D13794#289076, @tcberner wrote:

Then make it USE_PYQT=sip_run :)

It must be required during build too, so it should be USE_PYQT=sip.
It looks to me that the bug only induces the run dependency, but the build dependency is correct.

yep, USE_PYQT=sip will give you both a run and build depends.

yuri added a comment.Jan 8 2018, 7:16 PM
In D13794#289082, @tcberner wrote:

yep, USE_PYQT=sip will give you both a run and build depends.

Yes, but the question remains if this is a bug or not.
I am not sure how py-sip actually works. Always in the build time, or possibly also in runtime, like py-cffi does.

yuri added a comment.Jan 8 2018, 7:34 PM

I asked on the python@ ML about import PyQt5.QtCore requiring py-sip in the runtime.
I strongly suspect this is a bug. :)

tcberner added a comment.Jan 8 2018, 7:44 PM
In D13794#289111, @yuri wrote:

I asked on the python@ ML about import PyQt5.QtCore requiring py-sip in the runtime.
I strongly suspect this is a bug. :)

I think you should double check your grep for MAINTAINER there :D

yuri added a comment.Jan 8 2018, 7:54 PM
In D13794#289114, @tcberner wrote:

I think you should double check your grep for MAINTAINER there :D

Hmmm, the MAINTAINER looks pluperfect to me.
Is there a bug hiding there somewhere? :-)

tcberner added a comment.Jan 8 2018, 7:58 PM
In D13794#289120, @yuri wrote:
In D13794#289114, @tcberner wrote:

I think you should double check your grep for MAINTAINER there :D

Hmmm, the MAINTAINER looks pluperfect to me.
Is there a bug hiding there somewhere? :-)

What I meant is, that you should have directed that mail also at kde@ -- if you don't include the MAINTAINER of the port, how can you be sure, that the problem gets noticed?

yuri added a comment.Jan 8 2018, 8:06 PM
In D13794#289122, @tcberner wrote:

What I meant is, that you should have directed that mail also at kde@ -- if you don't include the MAINTAINER of the port, how can you be sure, that the problem gets noticed?

Yes, you are right!
Now I have forwarded it to kde@.

yuri updated this revision to Diff 37647.Jan 8 2018, 8:13 PM
yuri edited the summary of this revision. (Show Details)

Updated 'sip'.

Harbormaster completed remote builds in B14198: Diff 37647.Jan 8 2018, 8:13 PM
yuri updated this revision to Diff 37720.Jan 10 2018, 8:19 AM

I created the bug report for kde@ to fix the issue with sip.
Now that everything is clear, this can be committed.

Harbormaster completed remote builds in B14244: Diff 37720.Jan 10 2018, 8:19 AM
tcberner accepted this revision.Jan 19 2018, 8:02 PM

Ok, this is good to go. You can modify the sip dependency once py-qt5-core is fixed.

This revision is now accepted and ready to land.Jan 19 2018, 8:02 PM
Closed by commit rP460074: audio/carla: Update to 1.9.8 (authored by yuri). · Explain WhyJan 27 2018, 1:37 AM
This revision was automatically updated to reflect the committed changes.
yuri mentioned this in rP460074: audio/carla: Update to 1.9.8.

Revision Contents
Changeset List

PathSize
audio/
carla/
11 lines
6 lines

Diff 37720

View Options

audio/carla/Makefile

Loading...
View Options

audio/carla/distinfo

Loading...