Details

Reviewers

adridg
swills

Commits

rP457636: net-p2p/py-tremc: create port

Summary

This is a CLI transmission client. A python:3 fork (of the now abbandoned) transmission-remote-cli.

Test Plan

I am experiencing a weird behaviour while building this port with the XEROX (devel/py-xerox) option ON:

1 - if devel/py-xerox is already installed while building this port, make build it again and later fail due to devel/py-xerox
already being installed;

2 - if devel/py-xerox is not installed, make build it and later make fail with "tremc-20171202 depends on executable:
py36-xerox - not found". Same happens with Poudriere builds.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 13908
Build 14110: arc lint + arc unit

Event Timeline

rigoletto created this revision.Dec 25 2017, 3:46 PM

Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptDec 25 2017, 3:46 PM

rigoletto added a project: Python.Dec 25 2017, 3:47 PM

rigoletto edited the summary of this revision. (Show Details)Dec 25 2017, 3:49 PM

rigoletto edited the test plan for this revision. (Show Details)

rigoletto retitled this revision from New port net-p2p/tremc. to New port: net-p2p/tremc..Dec 25 2017, 3:52 PM

Fix typo in GEOIP_RUN_DEPENS.

Harbormaster completed remote builds in B13813: Diff 37023.Dec 26 2017, 1:29 AM

rigoletto edited the test plan for this revision. (Show Details)Dec 26 2017, 2:52 AM

Building fine now.

Thanks! :)

Harbormaster completed remote builds in B13818: Diff 37028.Dec 26 2017, 3:27 AM

ultima added a subscriber: ultima.Dec 26 2017, 4:42 AM

ultima added inline comments.

net-p2p/tremc/Makefile
4 ↗	(On Diff #37028)	Using USE_GITHUB When Upstream Does Not Use Versions should have g followed by the date. example: g20171202
5 ↗	(On Diff #37028)	why the "?"?
30 ↗	(On Diff #37028)	Mk/bsd.options.desc.mk already has the correct description. This can be removed.

Fixing.

Harbormaster completed remote builds in B13820: Diff 37030.Dec 26 2017, 4:53 AM

Done.
Thanks!

Updating distinfo.

Harbormaster completed remote builds in B13821: Diff 37031.Dec 26 2017, 5:26 AM

One more thing you can expect python@ team to bring up is [1], specifically PKGNAMEPREFIX missing and the port being named net-p2p/py-tremc. Not sure if it needs to follow these policies though because its not a standard python port.

[1] https://wiki.freebsd.org/Python/PortsPolicy

I completely forgot about the PKGNAMEPREFIX.

Fixing.
Thanks!

Harbormaster completed remote builds in B13835: Diff 37048.Dec 26 2017, 1:44 PM

Minor.

Harbormaster completed remote builds in B13837: Diff 37050.Dec 26 2017, 1:59 PM

rigoletto retitled this revision from New port: net-p2p/tremc. to New port: net-p2p/py-tremc..Dec 26 2017, 3:32 PM

rigoletto added a reviewer: adridg.Dec 28 2017, 5:20 PM

mat added inline comments.Dec 28 2017, 10:49 PM