Page MenuHomeFreeBSD
Differential D13500

Skip gnop tests if the module isn't available
ClosedPublic
Actions

Authored by markj on Dec 15 2017, 4:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 4, 6:37 PM
Unknown Object (File)
Thu, Sep 3, 4:10 PM
Unknown Object (File)
Thu, Sep 3, 3:27 PM
Unknown Object (File)
Tue, Sep 1, 11:47 PM
Unknown Object (File)
Tue, Sep 1, 11:42 PM
Unknown Object (File)
Tue, Sep 1, 11:40 PM
Unknown Object (File)
Tue, Sep 1, 2:07 PM
Unknown Object (File)
Tue, Sep 1, 12:43 PM
View All Files
Subscribers
imp
ngie

Details

Reviewers
asomers
Commits
rS326877: Skip gnop tests if the corresponding kernel module isn't available.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 13583
Build 13807: arc lint + arc unit

Event Timeline

markj created this revision.Dec 15 2017, 4:45 PM
Harbormaster completed remote builds in B13583: Diff 36629.Dec 15 2017, 4:45 PM
markj added a reviewer: asomers.Dec 15 2017, 4:45 PM
asomers accepted this revision.Dec 15 2017, 4:58 PM
asomers added a subscriber: ngie.

LGTM. Note that @ngie wrote a macro to do just this for ATF C tests. It's in tests/freebsd_test_suite/macros.h. But I don't think she ever wrote an sh version.

This revision is now accepted and ready to land.Dec 15 2017, 4:58 PM
Closed by commit rS326877: Skip gnop tests if the corresponding kernel module isn't available. (authored by markj). · Explain WhyDec 15 2017, 5:11 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptDec 15 2017, 5:11 PM

Revision Contents
Changeset List

PathSize
tests/
sys/
geom/
class/
nop/
11 lines

Diff 36629

View Options

tests/sys/geom/class/nop/nop_test.sh

Loading...