Page MenuHomeFreeBSD

New port: misc/libpostal: Library for parsing/normalizing street addresses around the world
ClosedPublic

Authored by yuri on Dec 12 2017, 11:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 2, 9:11 AM
Unknown Object (File)
Mon, Apr 22, 11:20 PM
Unknown Object (File)
Fri, Apr 19, 1:51 PM
Unknown Object (File)
Sat, Apr 13, 1:28 AM
Unknown Object (File)
Fri, Apr 12, 9:06 PM
Unknown Object (File)
Fri, Apr 12, 9:06 PM
Unknown Object (File)
Fri, Apr 12, 1:18 PM
Unknown Object (File)
Fri, Apr 12, 1:17 PM
Subscribers

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 13541
Build 13765: arc lint + arc unit

Event Timeline

dmgk added inline comments.
misc/libpostal/files/patch-src_Makefile.am
8

$(datadir) should be without libpostal suffix.

misc/libpostal/files/patch-test_Makefile.am
5

Same as above, should be just $(datadir) w/o suffix.

misc/libpostal/pkg-plist
11

This is not needed, LIBPOSTAL_DATADIR will be created by libpostal_data script on first data download.

misc/libpostal/Makefile
21

If we're not patching configure.ac, then configure needs CFLAGS and CPPFLAGS with -I${LOCALBASE}/include, otherwise CBLAS options is noop (configure doesn't find cblas.h)

misc/libpostal/files/patch-test_Makefile.am
5

This one is OK actually, please disregard.

misc/libpostal/pkg-plist
6

^ can you get rid of this, like in the other ports?

yuri marked an inline comment as done.Dec 13 2017, 6:12 AM
yuri added inline comments.
misc/libpostal/pkg-plist
6

Sorry, I forgot to mention. This port is going to be used in one go-package, and it appears that go needs static libraries. Submitter asked to leave it.

yuri marked 2 inline comments as done.Dec 13 2017, 6:12 AM
misc/libpostal/Makefile
40

Ports should not use static libraries. Doesn't math/openblas provide a shared library that this can use ?

51–52
post-install-DOCS-on:
misc/libpostal/pkg-plist
6

Go ports must not depend on static libraries, they must build everything they need themselves.

misc/libpostal/pkg-plist
6

Hi Tobias,

I'm ok with removing static libs, just wondering - is it a general policy in ports not to install static libs?

yuri marked 4 inline comments as done.Dec 13 2017, 5:24 PM

STATIC option has been added. STATIC=off by default.

misc/libpostal/Makefile
15

This should be just curl:ftp/curl.

51–52

You marked this as done, but it hasn't been done.

yuri added inline comments.
misc/libpostal/Makefile
51–52

Sorry, I missed this one. Now it's done.

yuri marked an inline comment as done.

.

This revision is now accepted and ready to land.Dec 18 2017, 10:38 PM
This revision was automatically updated to reflect the committed changes.