Page MenuHomeFreeBSD
Differential D13468

New port: misc/libpostal: Library for parsing/normalizing street addresses around the world
ClosedPublic
Actions

Authored by yuri on Dec 12 2017, 11:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 14, 9:57 PM
Unknown Object (File)
Mon, Apr 14, 8:09 AM
Unknown Object (File)
Sun, Mar 23, 10:14 PM
Unknown Object (File)
Mar 20 2025, 8:00 PM
Unknown Object (File)
Mar 18 2025, 12:47 PM
Unknown Object (File)
Feb 23 2025, 8:25 PM
Unknown Object (File)
Feb 15 2025, 3:23 PM
Unknown Object (File)
Feb 10 2025, 10:54 PM
View All Files
Subscribers
dmgk
mat

Details

Reviewers
tcberner
adamw
Commits
rP456691: New port: misc/libpostal: Library for parsing/normalizing street addresses…
Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224262

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 13521
Build 13745: arc lint + arc unit

Event Timeline

yuri created this revision.Dec 12 2017, 11:39 PM
Herald added a subscriber: mat. · View Herald TranscriptDec 12 2017, 11:39 PM
Harbormaster completed remote builds in B13517: Diff 36524.Dec 12 2017, 11:39 PM
dmgk added a subscriber: dmgk.Dec 12 2017, 11:50 PM
dmgk added inline comments.
misc/libpostal/files/patch-src_Makefile.am
8

$(datadir) should be without libpostal suffix.

misc/libpostal/files/patch-test_Makefile.am
5

Same as above, should be just $(datadir) w/o suffix.

misc/libpostal/pkg-plist
11

This is not needed, LIBPOSTAL_DATADIR will be created by libpostal_data script on first data download.

dmgk added inline comments.Dec 12 2017, 11:55 PM
misc/libpostal/Makefile
21

If we're not patching configure.ac, then configure needs CFLAGS and CPPFLAGS with -I${LOCALBASE}/include, otherwise CBLAS options is noop (configure doesn't find cblas.h)

dmgk added inline comments.Dec 12 2017, 11:57 PM
misc/libpostal/files/patch-test_Makefile.am
5

This one is OK actually, please disregard.

yuri marked 5 inline comments as done.Dec 13 2017, 12:04 AM
yuri updated this revision to Diff 36527.Dec 13 2017, 12:04 AM

.

yuri updated this revision to Diff 36528.Dec 13 2017, 12:36 AM

.

Harbormaster completed remote builds in B13521: Diff 36528.Dec 13 2017, 12:36 AM
tcberner added inline comments.Dec 13 2017, 5:58 AM
misc/libpostal/pkg-plist
5

^ can you get rid of this, like in the other ports?

yuri marked an inline comment as done.Dec 13 2017, 6:12 AM
yuri added inline comments.
misc/libpostal/pkg-plist
5

Sorry, I forgot to mention. This port is going to be used in one go-package, and it appears that go needs static libraries. Submitter asked to leave it.

yuri marked 2 inline comments as done.Dec 13 2017, 6:12 AM
mat added inline comments.Dec 13 2017, 8:56 AM
misc/libpostal/Makefile
39

Ports should not use static libraries. Doesn't math/openblas provide a shared library that this can use ?

50–51
post-install-DOCS-on:
misc/libpostal/pkg-plist
5

Go ports must not depend on static libraries, they must build everything they need themselves.

dmgk added inline comments.Dec 13 2017, 1:31 PM
misc/libpostal/pkg-plist
5

Hi Tobias,

I'm ok with removing static libs, just wondering - is it a general policy in ports not to install static libs?

yuri updated this revision to Diff 36543.Dec 13 2017, 2:29 PM

Removed static libs.

yuri updated this revision to Diff 36552.Dec 13 2017, 5:24 PM

.

Harbormaster completed remote builds in B13537: Diff 36552.Dec 13 2017, 5:24 PM
yuri marked 4 inline comments as done.Dec 13 2017, 5:24 PM
yuri updated this revision to Diff 36556.Dec 13 2017, 5:55 PM

STATIC option has been added. STATIC=off by default.

Harbormaster completed remote builds in B13541: Diff 36556.Dec 13 2017, 5:55 PM
yuri updated this revision to Diff 36558.Dec 13 2017, 6:01 PM

.

Harbormaster completed remote builds in B13543: Diff 36558.Dec 13 2017, 6:01 PM
adamw added inline comments.Dec 18 2017, 10:04 PM
misc/libpostal/Makefile
15

This should be just curl:ftp/curl.

50–51

You marked this as done, but it hasn't been done.

yuri marked 2 inline comments as done.Dec 18 2017, 10:19 PM
yuri added inline comments.
misc/libpostal/Makefile
50–51

Sorry, I missed this one. Now it's done.

yuri updated this revision to Diff 36729.Dec 18 2017, 10:19 PM
yuri marked an inline comment as done.

.

Harbormaster completed remote builds in B13650: Diff 36729.Dec 18 2017, 10:19 PM
adamw accepted this revision.Dec 18 2017, 10:38 PM
This revision is now accepted and ready to land.Dec 18 2017, 10:38 PM
Closed by commit rP456691: New port: misc/libpostal: Library for parsing/normalizing street addresses… (authored by yuri). · Explain WhyDec 18 2017, 10:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 36528

View Options

misc/Makefile

  • This file was added.
PropertyOld ValueNew Value
File Modenull100755
#!/bin/sh
/usr/bin/sed -i.bak "$@"
for x in "${@}" ; do
tobikUnsubmitted
Done
Inline Actions

This script always has exit status 0 which means that the blackbox
behavior now differs when DEVELOPER is set and when it is not. If
I introduce a syntax error in a sed expression the build will
continue unpatched anyway when it probably should abort like before.
Maybe add set -e or || exit 1 to the script or handle the error
case in some other way.

tobik: This script always has exit status 0 which means that the blackbox behavior now differs when…
swillsAuthorUnsubmitted
Done
Inline Actions

Sure, that's fine.

swills: Sure, that's fine.
if [ -f "${x}" ]; then
if cmp "${x}" "${x}".bak > /dev/null 2>&1 ; then
matUnsubmitted
Done
Inline Actions

cmp as a silent mode:

if cmp -s "${x}" "${x}".bak ; then
mat: cmp as a silent mode: ``` if cmp -s "${x}" "${x}".bak ; then ```
if [ ! -z "${REWARNFILE}" ]; then
echo sed failed: backup file same as original: ${x} >> ${REWARNFILE}
fi
bdreweryUnsubmitted
Done
Inline Actions

[ -f $blah ] doesn't generate output so the redirections aren't needed.

bdrewery: `[ -f $blah ]` doesn't generate output so the redirections aren't needed.
tobikUnsubmitted
Done
Inline Actions

Every file flagged here will always be prefixed with ${WRKDIR} which
seems redundant. WRKDIR can also be a pretty long path. Would it
make sense to strip it like what is done in the shebang and symlink
checks in qa.sh?

tobik: Every file flagged here will always be prefixed with ${WRKDIR} which seems redundant. WRKDIR…
swillsAuthorUnsubmitted
Done
Inline Actions

Good idea.

swills: Good idea.
fi
matUnsubmitted
Done
Inline Actions
if !cmp "${x}" "${x}".bak > /dev/null 2>&1; then

(or maybe without the !, not sure)

mat: ``` if !cmp "${x}" "${x}".bak > /dev/null 2>&1; then ``` (or maybe without the `!`, not sure)
fi
done
bdreweryUnsubmitted
Not Done
Inline Actions

You quoted the first if [ -f but then lost quotes everywhere else. It will be significant with filenames with spaces or globbing characters. Unlikely but trivial to avoid the problem.

bdrewery: You quoted the first `if [ -f` but then lost quotes everywhere else. It will be significant…
View Options

misc/libpostal/

  • This file was added.
PropertyOld ValueNew Value
File Modenull100755
#!/bin/sh
/usr/bin/sed -i.bak "$@"
for x in "${@}" ; do
tobikUnsubmitted
Done
Inline Actions

This script always has exit status 0 which means that the blackbox
behavior now differs when DEVELOPER is set and when it is not. If
I introduce a syntax error in a sed expression the build will
continue unpatched anyway when it probably should abort like before.
Maybe add set -e or || exit 1 to the script or handle the error
case in some other way.

tobik: This script always has exit status 0 which means that the blackbox behavior now differs when…
swillsAuthorUnsubmitted
Done
Inline Actions

Sure, that's fine.

swills: Sure, that's fine.
if [ -f "${x}" ]; then
if cmp "${x}" "${x}".bak > /dev/null 2>&1 ; then
matUnsubmitted
Done
Inline Actions

cmp as a silent mode:

if cmp -s "${x}" "${x}".bak ; then
mat: cmp as a silent mode: ``` if cmp -s "${x}" "${x}".bak ; then ```
if [ ! -z "${REWARNFILE}" ]; then
echo sed failed: backup file same as original: ${x} >> ${REWARNFILE}
fi
bdreweryUnsubmitted
Done
Inline Actions

[ -f $blah ] doesn't generate output so the redirections aren't needed.

bdrewery: `[ -f $blah ]` doesn't generate output so the redirections aren't needed.
tobikUnsubmitted
Done
Inline Actions

Every file flagged here will always be prefixed with ${WRKDIR} which
seems redundant. WRKDIR can also be a pretty long path. Would it
make sense to strip it like what is done in the shebang and symlink
checks in qa.sh?

tobik: Every file flagged here will always be prefixed with ${WRKDIR} which seems redundant. WRKDIR…
swillsAuthorUnsubmitted
Done
Inline Actions

Good idea.

swills: Good idea.
fi
matUnsubmitted
Done
Inline Actions
if !cmp "${x}" "${x}".bak > /dev/null 2>&1; then

(or maybe without the !, not sure)

mat: ``` if !cmp "${x}" "${x}".bak > /dev/null 2>&1; then ``` (or maybe without the `!`, not sure)
fi
done
bdreweryUnsubmitted
Not Done
Inline Actions

You quoted the first if [ -f but then lost quotes everywhere else. It will be significant with filenames with spaces or globbing characters. Unlikely but trivial to avoid the problem.

bdrewery: You quoted the first `if [ -f` but then lost quotes everywhere else. It will be significant…
View Options

misc/libpostal/Makefile

  • This file was added.
PropertyOld ValueNew Value
File Modenull100755
#!/bin/sh
/usr/bin/sed -i.bak "$@"
for x in "${@}" ; do
tobikUnsubmitted
Done
Inline Actions

This script always has exit status 0 which means that the blackbox
behavior now differs when DEVELOPER is set and when it is not. If
I introduce a syntax error in a sed expression the build will
continue unpatched anyway when it probably should abort like before.
Maybe add set -e or || exit 1 to the script or handle the error
case in some other way.

tobik: This script always has exit status 0 which means that the blackbox behavior now differs when…
swillsAuthorUnsubmitted
Done
Inline Actions

Sure, that's fine.

swills: Sure, that's fine.
if [ -f "${x}" ]; then
if cmp "${x}" "${x}".bak > /dev/null 2>&1 ; then
matUnsubmitted
Done
Inline Actions

cmp as a silent mode:

if cmp -s "${x}" "${x}".bak ; then
mat: cmp as a silent mode: ``` if cmp -s "${x}" "${x}".bak ; then ```
if [ ! -z "${REWARNFILE}" ]; then
echo sed failed: backup file same as original: ${x} >> ${REWARNFILE}
fi
bdreweryUnsubmitted
Done
Inline Actions

[ -f $blah ] doesn't generate output so the redirections aren't needed.

bdrewery: `[ -f $blah ]` doesn't generate output so the redirections aren't needed.
tobikUnsubmitted
Done
Inline Actions

Every file flagged here will always be prefixed with ${WRKDIR} which
seems redundant. WRKDIR can also be a pretty long path. Would it
make sense to strip it like what is done in the shebang and symlink
checks in qa.sh?

tobik: Every file flagged here will always be prefixed with ${WRKDIR} which seems redundant. WRKDIR…
swillsAuthorUnsubmitted
Done
Inline Actions

Good idea.

swills: Good idea.
fi
matUnsubmitted
Done
Inline Actions
if !cmp "${x}" "${x}".bak > /dev/null 2>&1; then

(or maybe without the !, not sure)

mat: ``` if !cmp "${x}" "${x}".bak > /dev/null 2>&1; then ``` (or maybe without the `!`, not sure)
fi
done
bdreweryUnsubmitted
Not Done
Inline Actions

You quoted the first if [ -f but then lost quotes everywhere else. It will be significant with filenames with spaces or globbing characters. Unlikely but trivial to avoid the problem.

bdrewery: You quoted the first `if [ -f` but then lost quotes everywhere else. It will be significant…
View Options

misc/libpostal/distinfo

  • This file was added.
PropertyOld ValueNew Value
File Modenull100755
#!/bin/sh
/usr/bin/sed -i.bak "$@"
for x in "${@}" ; do
tobikUnsubmitted
Done
Inline Actions

This script always has exit status 0 which means that the blackbox
behavior now differs when DEVELOPER is set and when it is not. If
I introduce a syntax error in a sed expression the build will
continue unpatched anyway when it probably should abort like before.
Maybe add set -e or || exit 1 to the script or handle the error
case in some other way.

tobik: This script always has exit status 0 which means that the blackbox behavior now differs when…
swillsAuthorUnsubmitted
Done
Inline Actions

Sure, that's fine.

swills: Sure, that's fine.
if [ -f "${x}" ]; then
if cmp "${x}" "${x}".bak > /dev/null 2>&1 ; then
matUnsubmitted
Done
Inline Actions

cmp as a silent mode:

if cmp -s "${x}" "${x}".bak ; then
mat: cmp as a silent mode: ``` if cmp -s "${x}" "${x}".bak ; then ```
if [ ! -z "${REWARNFILE}" ]; then
echo sed failed: backup file same as original: ${x} >> ${REWARNFILE}
fi
bdreweryUnsubmitted
Done
Inline Actions

[ -f $blah ] doesn't generate output so the redirections aren't needed.

bdrewery: `[ -f $blah ]` doesn't generate output so the redirections aren't needed.
tobikUnsubmitted
Done
Inline Actions

Every file flagged here will always be prefixed with ${WRKDIR} which
seems redundant. WRKDIR can also be a pretty long path. Would it
make sense to strip it like what is done in the shebang and symlink
checks in qa.sh?

tobik: Every file flagged here will always be prefixed with ${WRKDIR} which seems redundant. WRKDIR…
swillsAuthorUnsubmitted
Done
Inline Actions

Good idea.

swills: Good idea.
fi
matUnsubmitted
Done
Inline Actions
if !cmp "${x}" "${x}".bak > /dev/null 2>&1; then

(or maybe without the !, not sure)

mat: ``` if !cmp "${x}" "${x}".bak > /dev/null 2>&1; then ``` (or maybe without the `!`, not sure)
fi
done
bdreweryUnsubmitted
Not Done
Inline Actions

You quoted the first if [ -f but then lost quotes everywhere else. It will be significant with filenames with spaces or globbing characters. Unlikely but trivial to avoid the problem.

bdrewery: You quoted the first `if [ -f` but then lost quotes everywhere else. It will be significant…
View Options

misc/libpostal/files/

Loading...
View Options

misc/libpostal/files/patch-configure.ac

Loading...
View Options

misc/libpostal/files/patch-src_Makefile.am

Loading...
View Options

misc/libpostal/files/patch-src_libpostal__data

Loading...
View Options

misc/libpostal/files/patch-src_sparkey_Makefile.am

Loading...
View Options

misc/libpostal/files/patch-test_Makefile.am

Loading...
View Options

misc/libpostal/files/pkg-message.in

Loading...
View Options

misc/libpostal/pkg-descr

Loading...
View Options

misc/libpostal/pkg-plist

Loading...