Remove hard coded number of lun definition
ClosedPublic
Actions

Authored by bapt on Dec 11 2017, 1:43 PM.

Details

Reviewers

mav
manu

Commits

rS327673: MFC r326769:
rS326769: Remove hard coded number of lun definition

Summary

The number of lun is now exposed by the kernel, use it in ctlstat(1)
This allows ctlstat -l 1118 to actually work when having more than 1024 luns

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bapt created this revision.Dec 11 2017, 1:43 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 11 2017, 1:43 PM

Harbormaster completed remote builds in B13479: Diff 36456.Dec 11 2017, 1:43 PM

LGTM

This revision is now accepted and ready to land.Dec 11 2017, 1:53 PM

Looks good to me, but there are couple comments.

usr.bin/ctlstat/ctlstat.c
596 ↗	(On Diff #36456)	What for is this blank line here?
600 ↗	(On Diff #36456)	I am thinking whether failing here is a good thing. May be we could allow some compatibility by falling back to default?

manu added inline comments.Dec 11 2017, 2:31 PM

usr.bin/ctlstat/ctlstat.c
600 ↗	(On Diff #36456)	kern.cam.ctl.max_luns always exists (well since my commit introducing it), one should not have world/kernel that desync no ?

World/kernel sync is generally recommended, but the less we depend on it -- the better we are for our users.

bapt added inline comments.Dec 11 2017, 2:51 PM

usr.bin/ctlstat/ctlstat.c
600 ↗	(On Diff #36456)	backward compatibility does not hurt :)

Closed by commit rS326769: Remove hard coded number of lun definition (authored by bapt). · Explain WhyDec 11 2017, 2:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

usr.bin/

ctlstat/

ctlstat.c

28 lines

Diff 36462

View Options

head/usr.bin/ctlstat/ctlstat.c

Remove hard coded number of lun definitionClosedPublicActions