Executable doesn't link with these. They load some things dynamically.

ninja breaks with bad scripts.

This one isn't %%FOO%%-based. There is a mistake, it was meant to be ../lib

It also loads gtk dynamically.

but how does that make any sense? if you need/want alsa&pulse at runtime, add it to the run depends, also :)

conditions still aply :D -- I would sed in %%QT_PLUGINDIR%% instead of this whole thing "garbling a path together"-thingy -- also this should not be necesssary [tm].

I am not really familiar with this app. But it can make sense if these are optional runtime dependencies. This means that it will use them if they are present, and will also happily work without them. At least that's what the submitter claims. And I myself did link projects this way.

Conditionals apply in regular patches?

I meant an error in the patch does not negate, that just using QT_PLUGINDIR is what is needed :)

@${PY_FLAVOR}

This goes against everything we do in the Ports tree. Software must not tentatively try to use stuff that may, or not, be there.

If you build with alsa or pulseaudio, then also add it as run dependencies, so that it is used.

Or make them options so that users can choose which they want.

I made alsa and pulseaudio LIB_DEPENDS.

Does this really need gtk3 and qt5 ? It feels strange to require both.

They link to gtk for notifications to work on gtk systems. I guess, they try to cover both gtk2 and gtk3 based systems. For example, the qTox port also links to gtk20 for this reason.

Software must not tentatively try to use stuff that may, or not, be there.

@mat , Please look at USE_GNOME=glib20 gtk30 in this case. It only uses gtk to enable desktop notifications in case of gtk-based systems. Otherwise, this is a Qt app.

Don't you think this is good to load gtk dynamically and ignore failures? This eliminates unnecessary dependencies. It doesn't have to install gtk when it isn't really needed just to enable notification that aren't shown anyway.

So, it should really be USE_GNOME=glib20:build gtk30:build. Unfortunately, USE_GNOME=gtk30:build is broken.

What are you talking about ? I simply asked a question, which you answered, leave it at that.

Of course USE_GNOME=gtk30:build does not do what you ask, gtk30 is a shared library, it must not be used at build time only, otherwise the software will end up being broken in the end. (I don't care that it "dynamically links it at run-time" if it needs it, it needs it.)