Details
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| net-im/telegram-desktop/Makefile | ||
|---|---|---|
| 16 ↗ | (On Diff #36434) | ^ USES=python:build ? |
| 18 ↗ | (On Diff #36434) | ^ how are alsa and pulse only build depends? does it not link against libasound.so or libpulse.so? |
| 25 ↗ | (On Diff #36434) | ^ why does it not build with ninja? |
| net-im/telegram-desktop/files/gyp-patches | ||
| 8 ↗ | (On Diff #36434) | ^I would sed in %%QT_BINDIR%% instead of %%LOCALBASE%%/bin |
| 100 ↗ | (On Diff #36434) | ^ |
| 111 ↗ | (On Diff #36434) | ^ %%QT_LIBDIR%% |
| 136 ↗ | (On Diff #36434) | %%QMAKESPEC%% otherwise this will likely break with gcc |
| 148 ↗ | (On Diff #36434) | if you hardcode the path, use %%QT_BINDIR%%/moc or %%MOC%% |
| net-im/telegram-desktop/files/patch-Telegram_SourceFiles_main.cpp | ||
| 25 ↗ | (On Diff #36434) | ^%%QT_PLUGINDIR%%? or do they want ${PREFIX}/bin/lib/qt5/plugins? |
| net-im/telegram-desktop/Makefile | ||
|---|---|---|
| 18 ↗ | (On Diff #36434) | Executable doesn't link with these. They load some things dynamically. |
| 25 ↗ | (On Diff #36434) | ninja breaks with bad scripts. |
| net-im/telegram-desktop/files/patch-Telegram_SourceFiles_main.cpp | ||
| 25 ↗ | (On Diff #36434) | This one isn't %%FOO%%-based. There is a mistake, it was meant to be ../lib |
| net-im/telegram-desktop/Makefile | ||
|---|---|---|
| 18 ↗ | (On Diff #36434) | It also loads gtk dynamically. |
| net-im/telegram-desktop/Makefile | ||
|---|---|---|
| 18 ↗ | (On Diff #36434) | but how does that make any sense? if you need/want alsa&pulse at runtime, add it to the run depends, also :) |
| net-im/telegram-desktop/files/patch-Telegram_SourceFiles_main.cpp | ||
|---|---|---|
| 25 ↗ | (On Diff #36434) | conditions still aply :D -- I would sed in %%QT_PLUGINDIR%% instead of this whole thing "garbling a path together"-thingy -- also this should not be necesssary [tm]. |
| net-im/telegram-desktop/Makefile | ||
|---|---|---|
| 18 ↗ | (On Diff #36434) | I am not really familiar with this app. But it can make sense if these are optional runtime dependencies. This means that it will use them if they are present, and will also happily work without them. At least that's what the submitter claims. And I myself did link projects this way. |
| net-im/telegram-desktop/files/patch-Telegram_SourceFiles_main.cpp | ||
|---|---|---|
| 25 ↗ | (On Diff #36434) | Conditionals apply in regular patches? |
| net-im/telegram-desktop/files/patch-Telegram_SourceFiles_main.cpp | ||
|---|---|---|
| 25 ↗ | (On Diff #36434) | I meant an error in the patch does not negate, that just using QT_PLUGINDIR is what is needed :) |
You need to change the %%QT_PLUGIN_DIR%% thingy, as the current patch assumes, that qt5-libraires are installed in ${PREFIX}/bin/../lib/qt5 --which may not be the case. However, %%QT_PLUGIN_DIR%% will point to the correct path (and if not, then everything is broken anyway :) ).
Note, the applications gets installed to $PREFIX and Qt lies in $LOCALBASE which may be different, so the relative path shenanigans are wonky (of course its correct for 99.995% of the cases).
| net-im/telegram-desktop/Makefile | ||
|---|---|---|
| 15 ↗ | (On Diff #36442) | @${PY_FLAVOR} |
| 18 ↗ | (On Diff #36434) | This goes against everything we do in the Ports tree. Software must not tentatively try to use stuff that may, or not, be there. If you build with alsa or pulseaudio, then also add it as run dependencies, so that it is used. Or make them options so that users can choose which they want. |
| net-im/telegram-desktop/Makefile | ||
|---|---|---|
| 18 ↗ | (On Diff #36434) | I made alsa and pulseaudio LIB_DEPENDS. |
| net-im/telegram-desktop/Makefile | ||
|---|---|---|
| 32–33 ↗ | (On Diff #36483) | Does this really need gtk3 and qt5 ? It feels strange to require both. |
| net-im/telegram-desktop/Makefile | ||
|---|---|---|
| 32–33 ↗ | (On Diff #36483) | They link to gtk for notifications to work on gtk systems. I guess, they try to cover both gtk2 and gtk3 based systems. For example, the qTox port also links to gtk20 for this reason. |
| net-im/telegram-desktop/Makefile | ||
|---|---|---|
| 18 ↗ | (On Diff #36434) |
@mat , Please look at USE_GNOME=glib20 gtk30 in this case. It only uses gtk to enable desktop notifications in case of gtk-based systems. Otherwise, this is a Qt app. Don't you think this is good to load gtk dynamically and ignore failures? This eliminates unnecessary dependencies. It doesn't have to install gtk when it isn't really needed just to enable notification that aren't shown anyway. So, it should really be USE_GNOME=glib20:build gtk30:build. Unfortunately, USE_GNOME=gtk30:build is broken. |
| net-im/telegram-desktop/Makefile | ||
|---|---|---|
| 18 ↗ | (On Diff #36434) | What are you talking about ? I simply asked a question, which you answered, leave it at that. Of course USE_GNOME=gtk30:build does not do what you ask, gtk30 is a shared library, it must not be used at build time only, otherwise the software will end up being broken in the end. (I don't care that it "dynamically links it at run-time" if it needs it, it needs it.) |
Telegram is famous, and has some non-trivial content like some shady organizations' chans, and has features requiring the server pull, like offline messages.
But security-wise I still think serverless messengers are much more secure, ex. qTox/Bitmessage/Ring.