Differential D13423

Fix the act_scan_laundry_weight mechanism.
ClosedPublic
Actions

Authored by markj on Dec 8 2017, 4:49 PM.

Tags

None

Referenced Files

	F172241279: D13423.id.diff
	Thu, Sep 17, 4:23 AM

	Unknown Object (File)
	Fri, Aug 28, 11:59 PM

	Unknown Object (File)
	Fri, Aug 28, 11:59 PM

	Unknown Object (File)
	Fri, Aug 28, 11:58 PM

	Unknown Object (File)
	Aug 16 2026, 8:40 AM

	Unknown Object (File)
	Jul 30 2026, 10:41 AM

	Unknown Object (File)
	Jun 27 2026, 9:29 AM

	Unknown Object (File)
	Jun 5 2026, 7:41 PM

Subscribers

Details

Reviewers

alc
kib

Commits

rS326732: Fix the act_scan_laundry_weight mechanism.

Summary

In r292392 I modified the active queue scan to weigh clean pages
differently from dirty pages when attempting to meet the inactive queue
target. Specifically, I wanted clean pages to count more towards the
target, since they can be reclaimed with less work. Moreover, moving
more dirty pages to the laundry queue improves our ability to cluster
them when writing.

When r306706 was merged into the PQ_LAUNDRY branch, this mechanism was
broken. Fix it by scalaing the correct page shortage variable.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13437
Build 13667: arc lint + arc unit

Event Timeline

markj created this revision.Dec 8 2017, 4:49 PM

Harbormaster completed remote builds in B13437: Diff 36388.Dec 8 2017, 4:49 PM

markj added reviewers: alc, kib.Dec 8 2017, 4:58 PM

kib accepted this revision.Dec 8 2017, 5:19 PM

This revision is now accepted and ready to land.Dec 8 2017, 5:19 PM

alc accepted this revision.Dec 8 2017, 5:36 PM

Closed by commit rS326732: Fix the act_scan_laundry_weight mechanism. (authored by markj). · Explain WhyDec 9 2017, 3:47 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptDec 9 2017, 3:47 PM

Revision Contents
Changeset List

Path

Size

sys/

vm/

2 lines

Diff 36388

sys/vm/vm_pageout.c

Loading...