Paths

Table of Contentst

Differential D13238

New port: audio/fluidplug-lv2: SoundFonts as LV2 plugins via FluidSynth
ClosedPublic
Actions

Authored by yuri on Nov 25 2017, 6:28 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 3, 4:58 PM

	Unknown Object (File)
	Tue, Dec 3, 8:30 AM

	Unknown Object (File)
	Mon, Dec 2, 3:32 AM

	Unknown Object (File)
	Fri, Nov 29, 10:58 AM

	Unknown Object (File)
	Nov 19 2024, 4:22 PM

	Unknown Object (File)
	Nov 19 2024, 4:22 PM

	Unknown Object (File)
	Nov 19 2024, 4:22 PM

	Unknown Object (File)
	Nov 19 2024, 4:16 PM

Subscribers

Details

Reviewers

tcberner
adamw
mat

Commits

rP455774: New port: audio/fluidplug-lv2: SoundFonts as LV2 plugins via FluidSynth

Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221486

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

yuri created this revision.Nov 25 2017, 6:28 AM

Herald added a subscriber: mat. · View Herald TranscriptNov 25 2017, 6:28 AM

Harbormaster completed remote builds in B13043: Diff 35755.Nov 25 2017, 6:28 AM

.

Harbormaster completed remote builds in B13044: Diff 35756.Nov 25 2017, 6:38 AM

tcberner added inline comments.Nov 25 2017, 9:35 AM

audio/fluidplug-lv2/Makefile
15 ↗	(On Diff #35756)	^ new port: sort :)

yuri marked an inline comment as done.Nov 25 2017, 9:41 AM

.

Harbormaster completed remote builds in B13049: Diff 35762.Nov 25 2017, 9:41 AM

tcberner added inline comments.Nov 25 2017, 1:43 PM

audio/fluidplug-lv2/Makefile.list
26 ↗	(On Diff #35762)	^ close one, let's hope they don't add two more :D

Replaced the repetitious statements with for clauses.

Harbormaster completed remote builds in B13059: Diff 35778.Nov 25 2017, 8:57 PM

yuri marked an inline comment as done.Nov 25 2017, 8:57 PM

mat requested changes to this revision.Nov 27 2017, 1:30 PM

mat added inline comments.

audio/fluidplug-lv2/Makefile
23 ↗	(On Diff #35778)	Default, remove.
audio/fluidplug-lv2/Makefile.list
3–5 ↗	(On Diff #35778)	First, this is better written as: MASTER_SITES+= http://download.linuxaudio.org/musical-instrument-libraries/sf2/AVL-Drumkits-1.1-SF2-splitted/:b,c,d,e,f,g Second, this is better written as simply `:b` (or some other group with a more descriptive name) and use `:b` for all the distfiles that need this particular directory.

This revision now requires changes to proceed.Nov 27 2017, 1:30 PM

.

Harbormaster completed remote builds in B13110: Diff 35866.Nov 27 2017, 5:32 PM

yuri marked an inline comment as done.Nov 27 2017, 5:32 PM

mat added inline comments.Nov 27 2017, 5:39 PM

audio/fluidplug-lv2/Makefile.list
4 ↗	(On Diff #35866)	Duplicate.

.

Harbormaster completed remote builds in B13116: Diff 35873.Nov 27 2017, 5:46 PM

Fixed.

@mat Anything else here?

mat accepted this revision.Dec 4 2017, 1:27 PM

This revision is now accepted and ready to land.Dec 4 2017, 1:27 PM

@tcberner Tobias, can this be committed?

@tcberner It shows it as "Accepted" and ready to land, but there is no your approval there. :)

Woops, I thought I already accepted this :) -- sorry

tcberner accepted this revision.Dec 8 2017, 6:15 AM

In D13238#280367, @tcberner wrote:

Woops, I thought I already accepted this :) -- sorry

No problem! -)

Closed by commit rP455774: New port: audio/fluidplug-lv2: SoundFonts as LV2 plugins via FluidSynth (authored by yuri). · Explain WhyDec 8 2017, 7:00 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

audio/

1 line

fluidplug-lv2/

39 lines

29 lines

53 lines

4 lines

376 lines

Diff 36378

head/audio/Makefile

Loading...

head/audio/fluidplug-lv2/Makefile

Loading...

head/audio/fluidplug-lv2/Makefile.list

Loading...

head/audio/fluidplug-lv2/distinfo

Loading...

head/audio/fluidplug-lv2/pkg-descr

Loading...

head/audio/fluidplug-lv2/pkg-plist

Loading...